From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2] pinctrl: qcom: remove gpiochip in failure cases Date: Fri, 29 Aug 2014 11:57:46 -0700 Message-ID: <20140829185744.GK12494@sonymobile.com> References: <1409299909-5128-1-git-send-email-pramod.gurav@smartplayin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from seldrel01.sonyericsson.com ([212.209.106.2]:3401 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbaH2S5q (ORCPT ); Fri, 29 Aug 2014 14:57:46 -0400 Content-Disposition: inline In-Reply-To: <1409299909-5128-1-git-send-email-pramod.gurav@smartplayin.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Pramod Gurav Cc: "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Linus Walleij , "Ivan T. Ivanov" On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > This patch releases gpiochip related resources by calling > gpiochip_remove when either of gpiochip_add_pin_range and > gpiochip_irqchip_add fails. > > CC: Linus Walleij > CC: Bjorn Andersson > CC: "Ivan T. Ivanov" > Signed-off-by: Pramod Gurav Acked-by: Bjorn Andersson > --- > > Changes since v1: > - In v1 of this patch gpiochip_remove was called only in failure case of > gpiochip_irqchip_add. This patchs adds a call to gpiochip_remove in failure > case of gpiochip_add_pin_range as well. > > drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 2738108..9175bbc 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -829,6 +829,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > ret = gpiochip_add_pin_range(&pctrl->chip, dev_name(pctrl->dev), 0, 0, chip->ngpio); > if (ret) { > dev_err(pctrl->dev, "Failed to add pin range\n"); > + gpiochip_remove(&pctrl->chip); > return ret; > } > > @@ -839,6 +840,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > IRQ_TYPE_NONE); > if (ret) { > dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n"); > + gpiochip_remove(&pctrl->chip); > return -ENOSYS; > } > It seems like pinctrl-st.c and pinctrl-sirf.c is suffering the same problem, would you mind spinning patches for those too? Regards, Bjorn