From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Sachin Kamat <spk.linux@gmail.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
"pramod.gurav@smartplayin.com" <pramod.gurav@smartplayin.com>,
Rob Herring <rob.herring@linaro.org>,
Mike Turquette <mike.turquette@linaro.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>
Subject: Re: [PATCHv2 2/4] cpufreq: cpufreq-dt: extend with platform_data
Date: Wed, 10 Sep 2014 14:28:41 +0200 [thread overview]
Message-ID: <20140910142841.17ae320a@free-electrons.com> (raw)
In-Reply-To: <CAKohpokH4ZoM=+i3wW73o_Xf26ysBaXbNNzGUB0ofcc0EkK3WA@mail.gmail.com>
Dear Viresh Kumar,
On Wed, 10 Sep 2014 17:52:59 +0530, Viresh Kumar wrote:
> On 10 September 2014 17:38, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > + dt_cpufreq_driver.driver_data = dev_get_platdata(&pdev->dev);
>
> I don't think this is right. What if platform device's platform data
> is freed later?
> That's why its always better to duplicate that structure instead of playing with
> pointers.
Isn't the piece of code registering the platform_device supposed to
make sure that platform_data doesn't disappear? At least, in PATCH 3/4,
I'm using platform_device_register_data(), which does a kmemdup() of
the custom data being passed before assigning the struct
device->platform_data field.
But if you like, I can add one more memory copy :)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-10 12:28 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 4:29 [PATCH] cpufreq: dt: Support platforms with separate clock lines for each CPU Viresh Kumar
2014-09-10 6:29 ` Thomas Petazzoni
2014-09-10 6:42 ` Viresh Kumar
2014-09-10 9:41 ` [PATCH 0/4] cpufreq-dt, platform_data based proposal Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 1/4] cpufreq: allow driver-specific flags Thomas Petazzoni
2014-09-10 10:49 ` Viresh Kumar
2014-09-27 22:44 ` Mike Turquette
2014-09-29 8:54 ` Viresh Kumar
[not found] ` <20141005004102.4379.42626@quantum>
2014-10-06 3:56 ` Viresh Kumar
[not found] ` <20141006183624.4379.26437@quantum>
2014-10-06 18:55 ` Thomas Petazzoni
2014-10-06 21:44 ` Mike Turquette
2014-10-07 3:27 ` Viresh Kumar
2014-10-07 3:25 ` Viresh Kumar
2014-10-08 7:48 ` [PATCH 0/2] allow cpufreq drivers to export flags Mike Turquette
2014-10-08 7:48 ` [PATCH 1/2] cpufreq: add driver flag for sleepable transitions Mike Turquette
2014-10-08 7:48 ` [PATCH 2/2] cpufreq: new function to query driver for flags Mike Turquette
2014-10-08 7:54 ` [PATCH 0/2] allow cpufreq drivers to export flags Viresh Kumar
2014-10-08 8:11 ` Thomas Petazzoni
2014-10-08 8:19 ` Viresh Kumar
2014-10-09 0:01 ` Mike Turquette
2014-10-09 3:37 ` Viresh Kumar
2014-09-10 9:41 ` [PATCH 2/4] cpufreq: cpufreq-dt: extend with platform_data Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 3/4] ARM: mvebu: use the cpufreq-dt platform_data for independent clocks Thomas Petazzoni
2014-09-10 9:41 ` [PATCH 4/4] cpufreq: cpufreq-dt: remove warning about regulators Thomas Petazzoni
2014-09-10 10:30 ` Viresh Kumar
2014-09-10 9:53 ` [PATCH 0/4] cpufreq-dt, platform_data based proposal Arnd Bergmann
2014-09-10 10:10 ` Thomas Petazzoni
2014-09-10 10:19 ` Arnd Bergmann
2014-09-10 10:30 ` Thomas Petazzoni
2014-09-10 18:15 ` Stephen Boyd
2014-09-10 10:38 ` Viresh Kumar
2014-09-10 11:37 ` Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 " Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 1/4] cpufreq: allow driver-specific data Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 2/4] cpufreq: cpufreq-dt: extend with platform_data Thomas Petazzoni
2014-09-10 12:22 ` Viresh Kumar
2014-09-10 12:28 ` Thomas Petazzoni [this message]
2014-09-10 12:32 ` Viresh Kumar
2014-09-10 12:36 ` Arnd Bergmann
2014-09-10 12:08 ` [PATCHv2 3/4] ARM: mvebu: use the cpufreq-dt platform_data for independent clocks Thomas Petazzoni
2014-09-10 12:08 ` [PATCHv2 4/4] cpufreq: cpufreq-dt: adjust message related to regulators Thomas Petazzoni
2014-09-10 12:23 ` Viresh Kumar
2014-09-10 12:38 ` [PATCHv2 0/4] cpufreq-dt, platform_data based proposal Viresh Kumar
2014-09-23 9:26 ` Thomas Petazzoni
2014-10-06 7:19 ` Thomas Petazzoni
2014-10-06 22:53 ` Rafael J. Wysocki
2014-10-07 3:30 ` Viresh Kumar
2014-10-07 23:59 ` Rafael J. Wysocki
2014-10-08 5:51 ` Viresh Kumar
2014-10-12 20:25 ` Rafael J. Wysocki
2014-10-19 9:31 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910142841.17ae320a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.turquette@linaro.org \
--cc=nadavh@marvell.com \
--cc=pramod.gurav@smartplayin.com \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@linaro.org \
--cc=spk.linux@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.ab@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox