From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: ssbi: promote the driver to subsys level Date: Wed, 17 Sep 2014 09:03:05 -0700 Message-ID: <20140917160305.GH30918@lee--X1> References: <1410915594-15599-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ig0-f182.google.com ([209.85.213.182]:53661 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755267AbaIQQDK (ORCPT ); Wed, 17 Sep 2014 12:03:10 -0400 Received: by mail-ig0-f182.google.com with SMTP id hn15so408386igb.3 for ; Wed, 17 Sep 2014 09:03:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410915594-15599-1-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: David Brown , Daniel Walker , Samuel Ortiz , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 17 Sep 2014, Srinivas Kandagatla wrote: > This patch promtes the driver to be at subsystem level as this driver > will be used by gpio controller drivers which inturn are used by many > platform drivers. Any reason why you're not using -EPROBE? > Signed-off-by: Srinivas Kandagatla > --- > drivers/mfd/ssbi.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c > index b78942e..4fbe02e 100644 > --- a/drivers/mfd/ssbi.c > +++ b/drivers/mfd/ssbi.c > @@ -331,7 +331,12 @@ static struct platform_driver ssbi_driver =3D { > .of_match_table =3D ssbi_match_table, > }, > }; > -module_platform_driver(ssbi_driver); > + > +static int ssbi_init(void) > +{ > + return platform_driver_register(&ssbi_driver); > +} > +subsys_initcall(ssbi_init); > =20 > MODULE_LICENSE("GPL v2"); > MODULE_VERSION("1.0"); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog