From: Mark Brown <broonie@kernel.org>
To: Andy Gross <agross@codeaurora.org>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: qup: Fix incorrect block transfers
Date: Wed, 24 Sep 2014 09:30:35 +0100 [thread overview]
Message-ID: <20140924083035.GY4015@sirena.org.uk> (raw)
In-Reply-To: <20140923192613.GA5975@qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Tue, Sep 23, 2014 at 02:26:13PM -0500, Andy Gross wrote:
> On Tue, Sep 23, 2014 at 12:24:27PM +0300, Ivan T. Ivanov wrote:
> > On Sun, 2014-09-21 at 23:27 -0500, Andy Gross wrote:
> > > This patch fixes a number of errors with the QUP block transfer mode. Errors
> > > manifested themselves as input underruns, output overruns, and timed out
> > > transactions.
> > At what speeds are you seeing those errors?
> We've tried 25MHz and 50MHz. Both fail in the same way. Keep in mind this is
> definitely a timing / race issue and it probably also dependent on the latency
> of the attached device. I cannot reproduce this at all on my IPQ8064 based
> board, but others can.
With SPI everything is entirely clocked from the master - the attached
device can't cause any of those issues unless there's an electrical
problem that *really* upsets the master.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-24 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 4:27 [PATCH] spi: qup: Fix incorrect block transfers Andy Gross
2014-09-23 9:24 ` Ivan T. Ivanov
2014-09-23 19:26 ` Andy Gross
2014-09-24 8:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924083035.GY4015@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox