From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH resend] arm:extend the reserved memory for initrd to be page aligned Date: Thu, 25 Sep 2014 15:31:42 +0100 Message-ID: <20140925143142.GF5182@n2100.arm.linux.org.uk> References: <35FD53F367049845BC99AC72306C23D103D6DB49161F@CNBJMBX05.corpusers.net> <20140919095959.GA2295@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20140919095959.GA2295@e104818-lin.cambridge.arm.com> Sender: owner-linux-mm@kvack.org To: Catalin Marinas , "Wang, Yalin" Cc: Will Deacon , "'linux-kernel@vger.kernel.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'linux-mm@kvack.org'" , "'linux-arm-msm@vger.kernel.org'" , 'Uwe =?iso-8859-1?Q?Kleine-K=F6nig'?= , DL-WW-ContributionOfficers-Linux List-Id: linux-arm-msm@vger.kernel.org On Fri, Sep 19, 2014 at 11:00:02AM +0100, Catalin Marinas wrote: > On Fri, Sep 19, 2014 at 08:09:47AM +0100, Wang, Yalin wrote: > > this patch extend the start and end address of initrd to be page alig= ned, > > so that we can free all memory including the un-page aligned head or = tail > > page of initrd, if the start or end address of initrd are not page > > aligned, the page can't be freed by free_initrd_mem() function. > >=20 > > Signed-off-by: Yalin Wang >=20 > Acked-by: Catalin Marinas >=20 > (as I said, if Russell doesn't have any objections please send the patc= h > to his patch system) I now have an objection. The patches in the emails were properly formatt= ed. The patches which were submitted to the patch system (there's two of them doing the same thing...) are not: --- ../kernel.torvalds.git.origin/arch/arm/mm/init.c 2014-09-24 16:24:= 06.863759000 +0800 +++ arch/arm/mm/init.c 2014-09-24 16:27:11.455456000 +0800 This is totally broken. Let's read the patch(1) man page: First, patch takes an ordered list of candidate file names as foll= ows: =B7 If the header is that of a context diff, patch takes the old = and new file names in the header. A name is ignored if it does not= have enough slashes to satisfy the -pnum or --strip=3Dnum option. T= he name /dev/null is also ignored. =B7 If there is an Index: line in the leading garbage and if eit= her the old and new names are both absent or if patch is conformin= g to POSIX, patch takes the name in the Index: line. =B7 For the purpose of the following rules, the candidate file na= mes are considered to be in the order (old, new, index), regardless of= the order that they appear in the header. Then patch selects a file name from the candidate list as follows: =B7 If some of the named files exist, patch selects the first = name if conforming to POSIX, and the best name otherwise. ... =B7 If no named files exist, no RCS, ClearCase, Perforce, or SCCS= master was found, some names are given, patch is not conforming to P= OSIX, and the patch appears to create a file, patch selects the best= name requiring the creation of the fewest directories. =B7 If no file name results from the above heuristics, you are as= ked for the name of the file to patch, and patch selects that name. ... NOTES FOR PATCH SENDERS There are several things you should bear in mind if you are going = to be sending out patches. ... If the recipient is supposed to use the -pN option, do not send o= utput that looks like this: diff -Naur v2.0.29/prog/README prog/README --- v2.0.29/prog/README Mon Mar 10 15:13:12 1997 +++ prog/README Mon Mar 17 14:58:22 1997 because the two file names have different numbers of slashes, and= dif- ferent versions of patch interpret the file names differently.= To avoid confusion, send output that looks like this instead: diff -Naur v2.0.29/prog/README v2.0.30/prog/README --- v2.0.29/prog/README Mon Mar 10 15:13:12 1997 +++ v2.0.30/prog/README Mon Mar 17 14:58:22 1997 So I'm going to reject this crap. --=20 FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org