From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v3 1/6] clk: qcom: Add support for GDSCs
Date: Mon, 23 Mar 2015 16:23:35 -0700
Message-ID: <20150323232335.GA24757@codeaurora.org>
References: <1426832483-27026-1-git-send-email-rnayak@codeaurora.org>
 <1426832483-27026-2-git-send-email-rnayak@codeaurora.org>
 <550BCE7C.3030000@linaro.org>
 <550BED93.3000305@codeaurora.org>
 <550BEFE0.1020004@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:50560 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751935AbbCWXXh (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Mon, 23 Mar 2015 19:23:37 -0400
Content-Disposition: inline
In-Reply-To: <550BEFE0.1020004@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, mturquette@linaro.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, georgi.djakov@linaro.org, svarbanov@mm-sol.com

On 03/20, Rajendra Nayak wrote:
> []...
> >>>@@ -0,0 +1,46 @@
> >>>+/*
> >>>+ * Copyright (c) 2015, The Linux Foundation. All rights reserved.
> >>>+ *
> >>>+ * This program is free software; you can redistribute it and/or modify
> >>>+ * it under the terms of the GNU General Public License version 2 and
> >>>+ * only version 2 as published by the Free Software Foundation.
> >>>+ *
> >>>+ * This program is distributed in the hope that it will be useful,
> >>>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
> >>>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> >>>+ * GNU General Public License for more details.
> >>>+ */
> >>>+
> >>>+#ifndef __QCOM_GDSC_H__
> >>>+#define __QCOM_GDSC_H__
> >>>+
> >>>+#include <linux/pm_domain.h>
> >>>+
> >>>+struct regmap;
> 
> I realized, after Srini pointed out on irc that this fwd declaration
> is a complete waste. I'll remove it when I do a repost.
> 

Why? It's there so that struct regmap is declared instead of
being declared inside struct gdsc.

> >>>+
> >>>+/**
> >>>+ * struct gdsc - Globally Distributed Switch Controller
> >>>+ * @pd: generic power domain
> >>>+ * @regmap: regmap for MMIO accesses
> >>>+ * @gdscr: gsdc control register
> >>>+ */
> >>>+struct gdsc {
> >>>+    struct generic_pm_domain    pd;
> >>>+    struct regmap            *regmap;
> >>>+    unsigned int            gdscr;
> >>>+};
> >>>+
> >>>+#define domain_to_gdsc(domain) container_of(domain, struct gdsc, pd)
> >>>+
> >>>+#ifdef CONFIG_QCOM_GDSC
> >>>+int gdsc_register(struct device *, struct gdsc **, size_t n, struct
> >>>regmap *);
> >>>+void gdsc_unregister(struct device *);
> >>>+#else
> >>>+int gdsc_register(struct device *d, struct gdsc **g, size_t n, struct
> >>>regmap *r)

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project