From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] spmi: add command tracepoints for SPMI Date: Tue, 19 May 2015 22:47:01 -0400 Message-ID: <20150519224701.7ac87489@grimm.local.home> References: <1431985887-23379-1-git-send-email-ankgupta@codeaurora.org> <555BD719.80508@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:54678 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752319AbbETCql (ORCPT ); Tue, 19 May 2015 22:46:41 -0400 In-Reply-To: <555BD719.80508@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Ankit Gupta , gavidov@codeaurora.org, sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, ivan.ivanov@linaro.org, linux-kernel@vger.kernel.org, svarbanov@mm-sol.com, galak@codeaurora.org, agross@codeaurora.org On Tue, 19 May 2015 17:36:41 -0700 Stephen Boyd wrote: > +Steven Rostedt > > On 05/18/15 14:51, Ankit Gupta wrote: > > Add tracepoints to retrieve information about read, write > > and non-data commands. For performance measurement support > > tracepoints are added at the beginning and at the end of > > transfers. Following is a list showing the new tracepoint > > events. The "cmd" parameter here represents the opcode, SID, > > and full 16-bit address. > > > > spmi_write_begin: cmd and data buffer. > > spmi_write_end : cmd and return value. > > spmi_read_begin : cmd. > > spmi_read_end : cmd, return value and data buffer. > > spmi_cmd : cmd. > > > > The reason that cmd appears at both the beginning and at > > the end event is that SPMI drivers can request commands > > concurrently. cmd helps in matching the corresponding > > events. > > > > SPMI tracepoints can be enabled like: > > > > echo 1 >/sys/kernel/debug/tracing/events/spmi/enable > > > > and will dump messages that can be viewed in > > /sys/kernel/debug/tracing/trace that look like: > > > > ... spmi_read_begin: opc=56 sid=00 addr=0x0000 > > ... spmi_read_end: opc=56 sid=00 addr=0x0000 ret=0 len=02 buf=0x[01-40] > > ... spmi_write_begin: opc=48 sid=00 addr=0x0000 len=3 buf=0x[ff-ff-ff] > > > > Signed-off-by: Ankit Gupta > > Signed-off-by: Gilad Avidov > > Suggested-by: Sagar Dharia > > --- > > Your Signed-off-by should be last. > The tracing part looks fine to me. For that: Acked-by: Steven Rostedt -- Steve