From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/3] of/slimbus: OF helper for SLIMbus Date: Mon, 15 Jun 2015 11:55:56 +0100 Message-ID: <20150615105556.GK18309@sirena.org.uk> References: <1434260958-13732-1-git-send-email-sdharia@codeaurora.org> <1434260958-13732-3-git-send-email-sdharia@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mGCtrYeZ202LI9ZG" Return-path: Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58300 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754218AbbFOK4d (ORCPT ); Mon, 15 Jun 2015 06:56:33 -0400 Content-Disposition: inline In-Reply-To: <1434260958-13732-3-git-send-email-sdharia@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sagar Dharia Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, bp@suse.de, poeschel@lemonage.de, santosh.shilimkar@ti.com, treding@nvidia.com, gong.chen@linux.intel.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, oded.gabbay@amd.com, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, daniel.thompson@linaro.org, nkaje@codeaurora.org, mbutler@audience.com, kheitke@audience.com, mlocke@codeaurora.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org --mGCtrYeZ202LI9ZG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jun 13, 2015 at 11:49:17PM -0600, Sagar Dharia wrote: > OF helper routine scans the SLIMbus DeviceTree, allocates resources, > and creates slim_devices according to the hierarchy. You've not provided any sort of binding documentation, that is a requirement for any new bindings and is really helpful for reviewing as without documentation we can't be 100% certain what the code is intended to do! --mGCtrYeZ202LI9ZG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVfq87AAoJECTWi3JdVIfQW1UH/3AMQ05YfmBxhWnws+r1x/yW 5ToV7lpAImyJ3c1mvG4ZymiPyMjq7MV7G0gRqWeCB4xQsun+VdxQkt1kPY0a3vFM gGEUogCD6brgRNjsbqrunmeK40zTJ3rI+bCmmE+OVMUXwEyE+wrJbqRQYYZQXelr H4IlhPZ3tHHKPoAxDk+GuVvNlk7Wjr5n3w+/tw3cQOT+nD2eL6izYvTKn+xMjstA +4uqNcFOPQ6zJFZoszIjIEg3dJz9B6idEL/Um/25Rl8P9yc7SUT+l00Pba4qUL/C 6wEEpwA4hJvCW7Qp8BR3TElkjMFKnY3vmYJBqKw+shpC58c7iXlAQOD6V8YidVE= =yb9p -----END PGP SIGNATURE----- --mGCtrYeZ202LI9ZG--