From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Date: Mon, 15 Jun 2015 12:01:36 +0100 Message-ID: <20150615110136.GJ7557@n2100.arm.linux.org.uk> References: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org> <1433272378-8470-2-git-send-email-sboyd@codeaurora.org> <20150615063324.GY18985@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:60511 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174AbbFOLBv (ORCPT ); Mon, 15 Jun 2015 07:01:51 -0400 Content-Disposition: inline In-Reply-To: <20150615063324.GY18985@pengutronix.de> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Stephen Boyd , Kevin Hilman , Ard Biesheuvel , linux-arm-msm@vger.kernel.org, Andy Gross , linux-kernel@vger.kernel.org, Lina Iyer , Kumar Gala , linux-arm-kernel@lists.infradead.org On Mon, Jun 15, 2015 at 08:33:25AM +0200, Uwe Kleine-K=F6nig wrote: > Hello, > > + .arm > > +ENTRY(cpu_resume_arm) > > + THUMB( badr r9, 1f ) @ Kernel is entered in ARM. > > + THUMB( bx r9 ) @ If this is a Thumb-2 kernel, > > + THUMB( .thumb ) @ switch to Thumb now. > > + THUMB(1: ) > > ENTRY(cpu_resume) > > ARM_BE8(setend be) @ ensure we are in BE mode > > #ifdef CONFIG_ARM_VIRT_EXT > this patch is in next as 51ac91b7f6b11b0da55ac93885ee7b864865bcb1 and > breaks efm32_defconfig. The exact error message is: >=20 > AS arch/arm/kernel/sleep.o > arch/arm/kernel/sleep.S: Assembler messages: > arch/arm/kernel/sleep.S:121: Error: selected processor does not suppo= rt ARM opcodes > arch/arm/kernel/sleep.S:123: Error: bad instruction `badr r9,1f' > arch/arm/kernel/sleep.S:124: Error: attempt to use an ARM instruction= on a Thumb-only processor -- `bx r9' > scripts/Makefile.build:294: recipe for target 'arch/arm/kernel/sleep.= o' failed > make[3]: *** [arch/arm/kernel/sleep.o] Error 1 Don't get me wrong, the build testing which goes on is really great, bu= t there's now a problem with all this. There needs to be coordination between the people doing the build tests to ensure that we don't "tire out" those who read the emails with diffe= rent groups of people reporting the same problem days after it was first discovered, and even worse, days after it's been fixed. The worst thing to do is to report build regressions on Monday for a tr= ee which was created on Thursday - by the time Monday comes around, projec= ts such as the 0-day builder have had plenty of time to find them. Remember, the linux-next tree which is published on Friday (Austrailian time) is a result of git trees snapshotted around midnight on Thursday. So, if you're going to build an old linux-next tree, before you report = any problems, please check whether other build systems have already reporte= d them. If you've gone to the trouble of tracking down the commit which caused it, and therefore the likely git tree, check whether a fix has already been merged. Or maybe wait until the post-weekend linux-next i= s published... (The problem you're referring to was fixed and pushed out on Friday - which seems to be a regular thing that happens with problems you've reported on Mondays...) --=20 =46TTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps u= p according to speedtest.net.