From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 1/2] ARM: Add cpu_resume_arm() for firmwares that resume in ARM state Date: Mon, 15 Jun 2015 15:38:10 +0200 Message-ID: <20150615133810.GA19996@pengutronix.de> References: <1433272378-8470-1-git-send-email-sboyd@codeaurora.org> <1433272378-8470-2-git-send-email-sboyd@codeaurora.org> <20150615063324.GY18985@pengutronix.de> <20150615110136.GJ7557@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:59822 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbFONiO (ORCPT ); Mon, 15 Jun 2015 09:38:14 -0400 Content-Disposition: inline In-Reply-To: <20150615110136.GJ7557@n2100.arm.linux.org.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Russell King - ARM Linux Cc: Kevin Hilman , Ard Biesheuvel , linux-arm-msm@vger.kernel.org, Kumar Gala , Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross , Lina Iyer Hello Russell, On Mon, Jun 15, 2015 at 12:01:36PM +0100, Russell King - ARM Linux wrot= e: > On Mon, Jun 15, 2015 at 08:33:25AM +0200, Uwe Kleine-K=F6nig wrote: > > Hello, > > > + .arm > > > +ENTRY(cpu_resume_arm) > > > + THUMB( badr r9, 1f ) @ Kernel is entered in ARM. > > > + THUMB( bx r9 ) @ If this is a Thumb-2 kernel, > > > + THUMB( .thumb ) @ switch to Thumb now. > > > + THUMB(1: ) > > > ENTRY(cpu_resume) > > > ARM_BE8(setend be) @ ensure we are in BE mode > > > #ifdef CONFIG_ARM_VIRT_EXT > > this patch is in next as 51ac91b7f6b11b0da55ac93885ee7b864865bcb1 a= nd > > breaks efm32_defconfig. The exact error message is: > >=20 > > AS arch/arm/kernel/sleep.o > > arch/arm/kernel/sleep.S: Assembler messages: > > arch/arm/kernel/sleep.S:121: Error: selected processor does not sup= port ARM opcodes > > arch/arm/kernel/sleep.S:123: Error: bad instruction `badr r9,1f' > > arch/arm/kernel/sleep.S:124: Error: attempt to use an ARM instructi= on on a Thumb-only processor -- `bx r9' > > scripts/Makefile.build:294: recipe for target 'arch/arm/kernel/slee= p.o' failed > > make[3]: *** [arch/arm/kernel/sleep.o] Error 1 >=20 > Don't get me wrong, the build testing which goes on is really great, = but > there's now a problem with all this. >=20 > There needs to be coordination between the people doing the build tes= ts > to ensure that we don't "tire out" those who read the emails with dif= ferent > groups of people reporting the same problem days after it was first > discovered, and even worse, days after it's been fixed. >=20 > The worst thing to do is to report build regressions on Monday for a = tree > which was created on Thursday - by the time Monday comes around, proj= ects > such as the 0-day builder have had plenty of time to find them. >=20 > Remember, the linux-next tree which is published on Friday (Austraili= an > time) is a result of git trees snapshotted around midnight on Thursda= y. >=20 > So, if you're going to build an old linux-next tree, before you repor= t any > problems, please check whether other build systems have already repor= ted > them. If you've gone to the trouble of tracking down the commit whic= h > caused it, and therefore the likely git tree, check whether a fix has > already been merged. Or maybe wait until the post-weekend linux-next= is > published... >=20 > (The problem you're referring to was fixed and pushed out on Friday - > which seems to be a regular thing that happens with problems you've > reported on Mondays...) I consulted Google (asking for the commit id) and checked the linux-arm-kernel list for reports which usually works well enough. But I understand your complaint, last time I introduced a build regression I got two automatic reports and three times the same fix int= o my mailbox. So I will try to be more careful in the future. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |