From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] firmware: qcom: scm: Peripheral Authentication Service Date: Thu, 2 Jul 2015 10:37:25 -0700 Message-ID: <20150702173725.GE9633@sonymobile.com> References: <1435693579-16109-1-git-send-email-bjorn.andersson@sonymobile.com> <559564AC.6030100@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from seldrel01.sonyericsson.com ([37.139.156.2]:2158 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbbGBRha (ORCPT ); Thu, 2 Jul 2015 13:37:30 -0400 Content-Disposition: inline In-Reply-To: <559564AC.6030100@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Kumar Gala , Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-soc@vger.kernel.org" On Thu 02 Jul 09:19 PDT 2015, Stephen Boyd wrote: > On 06/30/2015 12:46 PM, Bjorn Andersson wrote: > > + > > +int __qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size) > > +{ > > + dma_addr_t mdata_phys; > > + void *mdata_buf; > > + u32 scm_ret; > > + int ret; > > + struct pas_init_image_req { > > + u32 proc; > > + u32 image_addr; > > Please mark these as __le32 and do the appropriate conversions to little > endian. Just out of curiosity, are there any big endian systems out there that will run this code? Either way I will fix this, to follow the style of the other parts of this file. > Also consider removing the struct name and just make it > anonymous, i.e. > > struct { > __le32 proc; > __le32 image_addr; > } cmd; > Right, there's no reason to name these. Thanks, Bjorn