From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC v2 0/6] drm: fb emulation: Step 2: Create a fbdev emulation config option Date: Mon, 13 Jul 2015 09:15:01 +0200 Message-ID: <20150713071501.GK3736@phenom.ffwll.local> References: <1425980493-27533-1-git-send-email-architt@codeaurora.org> <1436769731-4816-1-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wg0-f50.google.com ([74.125.82.50]:34442 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbbGMHMR (ORCPT ); Mon, 13 Jul 2015 03:12:17 -0400 Received: by wgkl9 with SMTP id l9so18234680wgk.1 for ; Mon, 13 Jul 2015 00:12:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1436769731-4816-1-git-send-email-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Archit Taneja Cc: dri-devel@lists.freedesktop.org, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, airlied@linux.ie, treding@nvidia.com, p.zabel@pengutronix.de, benjamin.gaignard@linaro.org, jani.nikula@linux.intel.com On Mon, Jul 13, 2015 at 12:12:05PM +0530, Archit Taneja wrote: > This provides a uniform interface to enable/disable legacy fbdev support > for modesetting drivers. > > DRM_FBDEV_EMULATION is made available in the top level drm Kconfig. A > driver that wants fbdev emulation using drm_fb_helper can enable this > option. > > Apart from 5 drivers (msm, tegra, imx, sti, i915), all enable fbdev > emulation by default. For these drivers, if we explicitly disable fbdev > emulation, the 'hope' is that we will cleanly bail out with an error. We > set DRM_FBDEV_EMULATION to 'y' by default, since most drivers rely on it. > > > Archit Taneja (6): > drm: Add top level Kconfig option for DRM fbdev emulation > drm/msm: Remove local fbdev emulation Kconfig option > drm/tegra: Remove local fbdev emulation Kconfig option > drm/imx: Remove local fbdev emulation Kconfig option > drm/sti: Remove local fbdev emulation Kconfig option > drm/i915: Remove local fbdev emulation Kconfig option Ah I guess you can disregard some of my comments here. Since this was in-reply-to the old thread but step 1 wasn't I've read the patches out-of-order ;-) -Daniel > > drivers/gpu/drm/Kconfig | 12 +++ > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/i915/Kconfig | 15 --- > drivers/gpu/drm/i915/Makefile | 4 +- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 2 - > drivers/gpu/drm/i915/intel_display.c | 10 +- > drivers/gpu/drm/i915/intel_dp_mst.c | 14 +-- > drivers/gpu/drm/i915/intel_drv.h | 3 +- > drivers/gpu/drm/i915/intel_fbdev.c | 7 -- > drivers/gpu/drm/imx/Kconfig | 9 -- > drivers/gpu/drm/imx/imx-drm-core.c | 10 +- > drivers/gpu/drm/msm/Kconfig | 14 --- > drivers/gpu/drm/msm/Makefile | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 8 +- > drivers/gpu/drm/sti/Kconfig | 6 -- > drivers/gpu/drm/sti/sti_drm_drv.c | 2 +- > drivers/gpu/drm/tegra/Kconfig | 12 --- > drivers/gpu/drm/tegra/drm.c | 15 ++- > drivers/gpu/drm/tegra/drm.h | 8 -- > drivers/gpu/drm/tegra/fb.c | 25 ++--- > include/drm/drm_fb_helper.h | 192 +++++++++++++++++++++++++++++++++++ > 22 files changed, 242 insertions(+), 132 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch