From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers Date: Tue, 14 Jul 2015 10:02:04 +0200 Message-ID: <20150714080202.GA12465@ulmo.nvidia.com> References: <1436769848-4990-1-git-send-email-architt@codeaurora.org> <20150713153726.GY3736@phenom.ffwll.local> <55A4ACD7.6020001@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0693161555==" Return-path: In-Reply-To: <55A4ACD7.6020001@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: linux-arm-msm@vger.kernel.org, Maling list - DRI developers List-Id: linux-arm-msm@vger.kernel.org --===============0693161555== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 12:01:51PM +0530, Archit Taneja wrote: > Hi, >=20 > On 07/13/2015 09:07 PM, Daniel Vetter wrote: > >On Mon, Jul 13, 2015 at 11:30:34AM -0400, Alex Deucher wrote: > >>On Mon, Jul 13, 2015 at 2:43 AM, Archit Taneja = wrote: > >>>With the top level DRM_FBDEV_EMULATION option, drivers don't need to > >>>select DRM_FB_KMS_HELPER or other FB related config options in the > >>>driver. > >>> > >>>Even if FBDEV_EMULATION isn't select, the stubbed out versions of > >>>the drm_fb_helper functions will be called. > >>> > >>>There are some drivers which still need some FB stuff even after > >>>these changes. They are qxl, udl and nouveau. These are handled a bit > >>>differently compared to the other patches. > >> > >>Series is: > >>Acked-by: Alex Deucher > > > >Archit for merging I think I'll just keep the current set of patches I > >have for testing (well until there's a real bug discovered). Can you > >please collect all the acks/r-bs/t-d when resending so I don't have to > >digg them out when we merge the final versions of these? > > >=20 > Sure. I'll keep a track of this. >=20 > Speaking of bugs, there was one thing I noticed in the series which I > am not sure about. >=20 > One of the new helpers wraps around framebuffer_alloc(). Most drivers > tend to pass the drm_device's dev pointer to this, and this is what I > do in the helper too. >=20 > But some drivers(nouveau, radeon, qxl and some more) pass their > pci_dev's dev pointer. As far as I can tell, for all PCI drivers the drm_device's dev pointer is set to the pci_dev's dev pointer (via drm_get_pci_dev()), so this shouldn't be changing anything at all. Thierry --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVpMHxAAoJEN0jrNd/PrOhhMQQAJ45422fcMTNhOTJvkXjkBwb sD19m8K68SHqzDJIwUto1UARu4L/povPmGdD780I/Jswub3WyCR4jn9lruiL6SX1 m2aKgX+YlixPC9Kt3f+mV9+iY4cDaQ2tmkl6WlL+7ahE2+DxV9tA+N0IzwkvyzQZ lbZOnsVeqXJOnwfYIzRdIJ/FdXme3KIIeCkTwgmu8KsQwAqXxPckEYtwKUPIelH0 wySXsxYi6oNAvEvck2t9mAnanTlZhN43XE3NjNWjgF6/Ms8zFYqai4ORE4DdGORW PCP1bZN0ycUJ5hdrLBOzAMnQnikJKsLz0c86k1AhQLXzJikBF6boRhiXpBhoM8Ne pq2MRtiDeGmurZ47tbC132VsP5iE/6+voAHjzLvex9mLoLya4+El5egyGx21k+0A EkMKMbLYCL16aj8KiuzxniiUetrwuVjLOZzmEVGIMKhaIaFS+0jSS79cDeTVYOwi GncHf63XenDCRc8emXQv2rkAg3oA7AcAkg76Yk6UCIowQhr0uVyUtCjWhQM6FXaA NGplAS1TumlfJwnyQgo3SU2ZlUdgGT2UyDy8SUcxbrzgnCFcwHg6/YJPfOvOWzZK ozjU8EcCu+MBsl8z5aY5NsAS5ySTrqvy4OLLppBYyeBX6DfU9gyZ8rRCDeRWUUom JypPorOCIpXjFIJ7+lke =c4NB -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo-- --===============0693161555== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0693161555==--