Re: [PATCH 00/10] drm/misc: Kconfig cleanup

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2535 bytes --]

On Mon, Jul 13, 2015 at 12:06:23PM +0530, Archit Taneja wrote:
> The top level drm Kconfig is a bit messy at the moment. Most of the drm
> drivers have their own Kconfig files, but a few have their Kconfig files
> in the top level Kconfig option itself.
> 
> Create new Kconfig files for drivers that don't have one. This cleans up
> the Kconfig quite a bit
> 
> Archit Taneja (10):
>   drm/tdfx: clean up: create a separate Kconfig file
>   drm/r128: clean up: create a separate Kconfig file
>   drm/radeon: clean up: move config option to driver's own Kconfig file
>   drm/amdgpu: clean up: move config option to driver's own Kconfig file
>   drm/i810: clean up: create a separate Kconfig file
>   drm/mga: clean up: create a separate Kconfig file
>   drm/sis: clean up: create a separate Kconfig file
>   drm/via: clean up: create a separate Kconfig file
>   drm/savage: clean up: create a separate Kconfig file
>   drm/misc: clean up: group device specific Kconfigs
> 
>  drivers/gpu/drm/Kconfig            | 116 ++++++-------------------------------
>  drivers/gpu/drm/amd/amdgpu/Kconfig |  19 ++++++
>  drivers/gpu/drm/i810/Kconfig       |   8 +++
>  drivers/gpu/drm/mga/Kconfig        |   8 +++
>  drivers/gpu/drm/r128/Kconfig       |   8 +++
>  drivers/gpu/drm/radeon/Kconfig     |  21 +++++++
>  drivers/gpu/drm/savage/Kconfig     |   7 +++
>  drivers/gpu/drm/sis/Kconfig        |   8 +++
>  drivers/gpu/drm/tdfx/Kconfig       |   6 ++
>  drivers/gpu/drm/via/Kconfig        |   6 ++
>  10 files changed, 108 insertions(+), 99 deletions(-)
>  create mode 100644 drivers/gpu/drm/i810/Kconfig
>  create mode 100644 drivers/gpu/drm/mga/Kconfig
>  create mode 100644 drivers/gpu/drm/r128/Kconfig
>  create mode 100644 drivers/gpu/drm/savage/Kconfig
>  create mode 100644 drivers/gpu/drm/sis/Kconfig
>  create mode 100644 drivers/gpu/drm/tdfx/Kconfig
>  create mode 100644 drivers/gpu/drm/via/Kconfig

Looking at the current state of the top-level Kconfig file, I think it'd
be a good idea to sort it in some way once this series has been merged.
There are a bunch of options that are interleaved in completely non-
intuitive ways.

I'm not sure what the best ordering would be, but I'd suggest to at
least order them alphabetically. I think it'd also make sense to
separate out panel and bridge drivers so that they are listed at the
very bottom.

Perhaps also splitting legacy drivers and modesetting drivers might be
useful, though perhaps a little discriminatory...

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel