From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: Make _find_next_bit helper function inline
Date: Tue, 28 Jul 2015 14:45:37 -0700
Message-ID: <20150728144537.67d46b5714c99d25f0bb33fb@linux-foundation.org>
References: <1438110564-19932-1-git-send-email-cburden@codeaurora.org>
	<55B7F2C6.9010000@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:54837 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750739AbbG1Vpj (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Tue, 28 Jul 2015 17:45:39 -0400
In-Reply-To: <55B7F2C6.9010000@gmail.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Yury <yury.norov@gmail.com>
Cc: Cassidy Burden <cburden@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexey Klimov <klimov.linux@gmail.com>, "David S. Miller" <davem@davemloft.net>, Daniel Borkmann <dborkman@redhat.com>, Hannes Frederic Sowa <hannes@stressinduktion.org>, Lai Jiangshan <laijs@cn.fujitsu.com>, Mark Salter <msalter@redhat.com>, AKASHI Takahiro <takahiro.akashi@linaro.org>, Thomas Graf <tgraf@suug.ch>, Valentin Rothberg <valentinrothberg@gmail.com>, Chris Wilson <chris@chris-wilson.co.uk>

On Wed, 29 Jul 2015 00:23:18 +0300 Yury <yury.norov@gmail.com> wrote:

> But I think, before/after for x86 is needed as well.

That would be nice.

> And why don't you consider '__always_inline__'? Simple inline is only a 
> hint and
> guarantees nothing.

Yup.  My x86_64 compiler just ignores the "inline".  When I use
__always_inline, find_bit.o's text goes from 776 bytes to 863. 
Hopefully we get something in return for that bloat!


Also, if _find_next_bit() benefits from this then _find_next_bit_le()
will presumably also benefit.