From: Stephen Boyd <sboyd@codeaurora.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: mturquette@baylibre.com, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
georgi.djakov@linaro.org, svarbanov@mm-sol.com,
srinivas.kandagatla@linaro.org, sviau@codeaurora.org
Subject: Re: [PATCH v7 01/13] clk: qcom: Add support for GDSCs
Date: Mon, 3 Aug 2015 12:24:27 -0700 [thread overview]
Message-ID: <20150803192427.GA7096@codeaurora.org> (raw)
In-Reply-To: <1438076046-4706-2-git-send-email-rnayak@codeaurora.org>
On 07/28, Rajendra Nayak wrote:
> +
> +#define PWR_ON_MASK BIT(31)
> +#define EN_REST_WAIT_MASK GENMASK(23, 20)
> +#define EN_FEW_WAIT_MASK GENMASK(19, 16)
> +#define CLK_DIS_WAIT_MASK GENMASK(15, 12)
This trips up some static checker...
drivers/clk/qcom/gdsc.c:234:53: warning: cast truncates bits from
constant value (fffffffffff006 becomes fffff006)
So I think we can use GENMASK_ULL here instead.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-08-03 19:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 9:33 [PATCH v7 00/13] qcom: Add support for GDSCs Rajendra Nayak
2015-07-28 9:33 ` [PATCH v7 01/13] clk: " Rajendra Nayak
2015-07-31 16:22 ` Bjorn Andersson
2015-08-05 5:28 ` Rajendra Nayak
2015-08-03 19:24 ` Stephen Boyd [this message]
2015-08-05 5:31 ` Rajendra Nayak
2015-08-07 23:52 ` Stephen Boyd
2015-07-28 9:33 ` [PATCH v7 02/13] clk: qcom: gdsc: Prepare common clk probe to register gdscs Rajendra Nayak
2015-07-28 9:33 ` [PATCH v7 03/13] clk: qcom: gdsc: Use PM clocks to control gdsc clocks Rajendra Nayak
2015-07-28 9:33 ` [PATCH v7 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM Rajendra Nayak
2015-07-28 9:33 ` [PATCH v7 05/13] clk: qcom: gdsc: Enable an RCG before turing on the gdsc Rajendra Nayak
2015-07-28 9:33 ` [PATCH v7 06/13] clk: qcom: gdsc: Add support for Memory RET/OFF Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 07/13] clk: qcom: gdsc: Add support for ON only state Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 08/13] clk: qcom: gdsc: Add GDSCs in msm8916 GCC Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 09/13] clk: qcom: gdsc: Add GDSCs in msm8974 GCC Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 10/13] clk: qcom: gdsc: Add GDSCs in msm8974 MMCC Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 11/13] clk: qcom: gdsc: Add GDSCs in apq8084 GCC Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 12/13] clk: qcom: gdsc: Add GDSCs in apq8084 MMCC Rajendra Nayak
2015-07-31 14:54 ` Stanimir Varbanov
2015-08-06 10:31 ` Rajendra Nayak
2015-07-28 9:34 ` [PATCH v7 13/13] arm: dts: qcom: Add #power-domain-cells property Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803192427.GA7096@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=svarbanov@mm-sol.com \
--cc=sviau@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).