From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 5/5] arm: qcom: dts: Enable NAND node on IPQ8064 AP148 platform Date: Mon, 3 Aug 2015 13:58:29 -0700 Message-ID: <20150803205829.GA21068@codeaurora.org> References: <1421419702-17812-1-git-send-email-architt@codeaurora.org> <1438578498-32254-1-git-send-email-architt@codeaurora.org> <1438578498-32254-6-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35813 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755540AbbHCU6b (ORCPT ); Mon, 3 Aug 2015 16:58:31 -0400 Content-Disposition: inline In-Reply-To: <1438578498-32254-6-git-send-email-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Archit Taneja Cc: linux-mtd@lists.infradead.org, dehrenberg@google.com, cernekee@gmail.com, computersforpeace@gmail.com, linux-arm-msm@vger.kernel.org, agross@codeaurora.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org On 08/03, Archit Taneja wrote: > @@ -93,5 +115,19 @@ > sata@29000000 { > status = "ok"; > }; > + > + nand@1ac00000 { > + status = "ok"; > + > + pinctrl-0 = <&nand_pins>; > + pinctrl-names = "default"; > + > + nand-ecc-strength = <4>; > + nand-bus-width = <8>; > + }; > }; > }; > + > +&adm_dma { > + status = "ok"; > +}; I think the preference is to put the full path to the device in the dts file and then have status = "ok". So please move this into the soc node and give the correct offset, etc. like we've done for other nodes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project