From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: auo novatek 1080p video mode panel Date: Mon, 17 Aug 2015 13:38:20 +0200 Message-ID: <20150817113819.GI8453@ulmo.nvidia.com> References: <1437507362-20162-1-git-send-email-robdclark@gmail.com> <20150807131931.GA27639@ulmo> <20150810195420.GK6519@usrtlx11787.corpusers.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CNK/L7dwKXQ4Ub8J" Return-path: Received: from mail-pa0-f44.google.com ([209.85.220.44]:36097 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755092AbbHQLj0 (ORCPT ); Mon, 17 Aug 2015 07:39:26 -0400 Received: by pawq9 with SMTP id q9so9338071paw.3 for ; Mon, 17 Aug 2015 04:39:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150810195420.GK6519@usrtlx11787.corpusers.net> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Rob Clark , linux-arm-msm , "dri-devel@lists.freedesktop.org" --CNK/L7dwKXQ4Ub8J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 12:54:20PM -0700, Bjorn Andersson wrote: > On Fri 07 Aug 09:11 PDT 2015, Rob Clark wrote: >=20 > > On Fri, Aug 7, 2015 at 9:19 AM, Thierry Reding wrote: > > > On Tue, Jul 21, 2015 at 03:36:02PM -0400, Rob Clark wrote: > [..] > > >> +- compatible: should be "auo,novatek-1080p-vid" > > > > > > This looks a little generic for a compatible string. Can't we get at = the > > > specific panel model number that's been used? What if AUO ever produc= ed > > > some other Novatek panel with a 1080p resolution? > >=20 > > Maybe Sony or someone else can chime in? That somewhat generic name > > was all I could get from downstream android kernel. I'm sure there is > > a better possible name, although I have no means to find that out > > myself. > >=20 >=20 > We're working on it. >=20 > > > Also, what's the -vid suffix for? > >=20 > > the same panel seems to also work in cmd mode.. so idea was to have > > -vid and -cmd compat strings to choose which mode to operate in. > >=20 >=20 > An alternative would be to make it a bool property, to indicate video > mode - following how the framework is implemented. Please, let's not do either. This doesn't belong in the compatible string. The compatible string specifies the panel, and the panel supports both video and command modes. That's implied by the compatible string. Which mode to use is a configuration or policy decision and therefore doesn't belong in device tree. It should be up to the display driver to determine what the preferred mode of operation is. Thierry --CNK/L7dwKXQ4Ub8J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV0cerAAoJEN0jrNd/PrOhQ8QP/05PuTkT/dglXq2X9Gy0iSfU /rMFzYeBKyZdeNX8Z7gL8cr8B1gBar/tPTlzLZlSyToGaPKtZ3VC1ccAGiC7auk0 ZfsHtnsMTsoyS/VjA8SUaza80SPtWZN0j3RgMaI83We7Vp9MF6w7yYV3V6FXB0ht 746FRMOPFVyV9qsUuhmy3fLr4SJILn+YUaDVMT9AuOutDgdUMvxnAXDg48NkUi83 Xcp2rXTJ39gUlMFHEs+Mjxk1G8G9g3g1ikofJkKfygbnRVKcYabPaw8zwBmspavO JuUTJZd4cavgJil0sZ3xRHRNmlB+EtIBtaqg0WGBZxjyqK3VS7ynZONkDyMmbF1P WqXDScL+2Ns9gzPRQVkjkDJhkuLBFSDOX4P7XKbulXU9pC7nvXPJYkJ2VV6iLrfl xOhCnvQ4QXR65b3B92Ej26Pu/LDadcSW3UA59qeWfZeAIGmdXiwYXw8uLSvgs1lX 3yq5Wldcz6UJbnXvHAWCQ5fdd0QNZsFMOp6r/OK19/CgRRGp0ABRyIzhD9AGl8TL tDe1tziMXiDig3t7YtAdpEGA641JKpjv6mxWKMm1yf6MKlF6Tky3jbtpeUEAOjfO jInH5EJTrcZFekRMz36WYD1ZK9/jGJfGqI8H1gA+ERD8OcDAA73aichvf+0ReI1a 7mvjrtmdkDblUIbVO0Er =Sb12 -----END PGP SIGNATURE----- --CNK/L7dwKXQ4Ub8J--