From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/panel: auo novatek 1080p video mode panel Date: Mon, 17 Aug 2015 16:57:31 +0200 Message-ID: <20150817145730.GH6891@ulmo.nvidia.com> References: <1437507362-20162-1-git-send-email-robdclark@gmail.com> <20150807131931.GA27639@ulmo> <20150810195420.GK6519@usrtlx11787.corpusers.net> <20150817113819.GI8453@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e5bfZ/T2xnjpUIbw" Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:33126 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbHQO6h (ORCPT ); Mon, 17 Aug 2015 10:58:37 -0400 Received: by pabyb7 with SMTP id yb7so110319135pab.0 for ; Mon, 17 Aug 2015 07:58:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Clark Cc: Bjorn Andersson , linux-arm-msm , "dri-devel@lists.freedesktop.org" --e5bfZ/T2xnjpUIbw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 17, 2015 at 10:48:20AM -0400, Rob Clark wrote: > On Mon, Aug 17, 2015 at 7:38 AM, Thierry Reding > wrote: > > On Mon, Aug 10, 2015 at 12:54:20PM -0700, Bjorn Andersson wrote: > >> On Fri 07 Aug 09:11 PDT 2015, Rob Clark wrote: > >> > >> > On Fri, Aug 7, 2015 at 9:19 AM, Thierry Reding wrote: > >> > > On Tue, Jul 21, 2015 at 03:36:02PM -0400, Rob Clark wrote: > >> [..] > >> > >> +- compatible: should be "auo,novatek-1080p-vid" > >> > > > >> > > This looks a little generic for a compatible string. Can't we get = at the > >> > > specific panel model number that's been used? What if AUO ever pro= duced > >> > > some other Novatek panel with a 1080p resolution? > >> > > >> > Maybe Sony or someone else can chime in? That somewhat generic name > >> > was all I could get from downstream android kernel. I'm sure there = is > >> > a better possible name, although I have no means to find that out > >> > myself. > >> > > >> > >> We're working on it. > >> > >> > > Also, what's the -vid suffix for? > >> > > >> > the same panel seems to also work in cmd mode.. so idea was to have > >> > -vid and -cmd compat strings to choose which mode to operate in. > >> > > >> > >> An alternative would be to make it a bool property, to indicate video > >> mode - following how the framework is implemented. > > > > Please, let's not do either. This doesn't belong in the compatible > > string. The compatible string specifies the panel, and the panel > > supports both video and command modes. That's implied by the compatible > > string. > > > > Which mode to use is a configuration or policy decision and therefore > > doesn't belong in device tree. It should be up to the display driver to > > determine what the preferred mode of operation is. >=20 > I would call it a "system integrator decision".. and at least > currently we don't have anywhere better than DT for that. Maybe it's > one of those "if all you have is a hammer, everything looks like a > nail" things.. If it were a system integrator decision then I'd agree it should be parameterizable in DT. But to my knowledge you can run any command mode capable display in video mode just fine. Thierry --e5bfZ/T2xnjpUIbw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV0fZaAAoJEN0jrNd/PrOhUBUP/000760uoRqSoi1ZXrJwBsBH WgBNPG1cs7BDZ6QpxmOkqv5ZfDlzRIXeVOpbWqyHZJPmb5oelBfNxzp2EaoKYAPj 77wFdzh5wInulEfMhU3uWaNIQz5ZjsaJjWxNCb11kGGJcJsy8fcpLChrvmtHZKXh ze9LVRiw65N14z4gYDO7gaQQ7g0ASTphUtZrmPBAxU3IdukwzFU3f16yrdvcrhaf R17/7D2SO5i5oZW9AXzHCT7q5HGj7CH0VCNqeW+iojXDaw1XRDXMjGd5t+1cfNMC LoIV4Xc1yD2Ef0/sKyGMBvx9GVn2VbpVPJvpUwmWlXCT4FB4pfiYnG34VTd50iBF qa7wcaM3y64lZkbv5LZ/NDOcO833HvBW3FA3ZW61DiFlUZNON0bTG+wu0r1NwuO9 AMa4UGNwus51EPHl1ilpCLHmqivkbmEmPiCM/vMXobnmcl7kFwZ/zsWBGzR/n1vk gS9Niffn5CwpVlbiLofCSQRs5yUP21o9NpgEW5LWBsMO6NvIQ35zIp4Vrr49c88u 8rhG827dAgEHZorjhhTLbdsPi23sKHsTy5pfgoCMs2AcnSkD7JxVAyd43s9ova0J q/oSK6JekoscLYgYcD9udrJJkuT5+DFzUHn1ZSYulZ9Yooogv6ZQKbwKDLIlU0c8 SmSuj2GEJJDw8+HUN0Cq =2mQ7 -----END PGP SIGNATURE----- --e5bfZ/T2xnjpUIbw--