Re: [PATCH] drm/panel: auo novatek 1080p video mode panel

[Bjorn Andersson <bjorn.andersson@sonymobile.com>]

On Tue 21 Jul 12:36 PDT 2015, Rob Clark wrote:

[..]
> +++ b/Documentation/devicetree/bindings/panel/auo,novatek-1080p.txt
> @@ -0,0 +1,25 @@
> +AU Optronics Corporation 1080x1920 DSI panel
> +
> +This panel supports both video and command mode (although currently only video
> +mode is implemented in the driver.
> +
> +Required properties:
> +- compatible: should be "auo,novatek-1080p-vid"

The panel name is AUO H515DAN02.0

> +
> +Optional properties:
> +- power-supply: phandle of the regulator that provides the supply voltage
> +- reset-gpio: phandle of gpio for reset line
> +- backlight: phandle of the backlight device attached to the panel
> +
[..]
> diff --git a/drivers/gpu/drm/panel/panel-auo-novatek-1080p.c b/drivers/gpu/drm/panel/panel-auo-novatek-1080p.c
[..]
> +
> +static int auo_panel_init(struct auo_panel *auo)
> +{
[..]
> +	ret = mipi_dsi_dcs_write(dsi, 0x3b, (u8[]){ 0x03, 0x30, 0x06 }, 3);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = mipi_dsi_dcs_write(dsi, 0xbb, (u8[]){ 0x10 }, 1);

This should be 0x3 for video mode and 0x10 for command mode.

> +	if (ret < 0)
> +		return ret;
> +	msleep(1);
> +
> +	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> +	if (ret < 0)
> +		return ret;
> +	msleep(30);
> +
> +	return 0;
> +}
> +

Regards,
Bjorn