From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Olof Johansson <olof@lixom.net>
Cc: "Masahiro Yamada" <yamada.masahiro@socionext.com>,
"arm@kernel.org" <arm@kernel.org>,
"Andy Gross" <agross@codeaurora.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Gregory Clement" <gregory.clement@free-electrons.com>,
"Tsahee Zidenberg" <tsahee@annapurnalabs.com>,
"Kumar Gala" <galak@codeaurora.org>,
"Jason Cooper" <jason@lakedaemon.net>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Jun Nie" <jun.nie@linaro.org>, "Ray Jui" <rjui@broadcom.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"David Brown" <davidb@codeaurora.org>,
"Scott Branden" <sbranden@broadcom.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>
Subject: Re: [PATCH 00/18] ARM: use const and __initconst for smp_operations
Date: Mon, 24 Aug 2015 22:21:27 +0100 [thread overview]
Message-ID: <20150824212127.GH7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAOesGMjku09wsUmwooq2ZXLyV7CPfioi0oAV5EgvW_wE98VYeg@mail.gmail.com>
On Mon, Aug 24, 2015 at 02:12:06PM -0700, Olof Johansson wrote:
> Easiest of all would probably be to get the sub-arch patches into one
> release, then switch the prototypes and function definitions in the
> next. If you switch prototypes first you'll get a bunch of warnings,
> right?
Wrong way around. :)
If you change the sub-arches to declare the smp operations as const,
and try and pass them into a function which doesn't take a const-pointer,
you'll get a warning. The core bits need to go in first before the
sub-arch patches.
I think the series has limited value - it allows us to (a) check that a
small quantity of code doesn't write to these things, and (b) allows us
to move the SMP operations structure from __initdata to __initconstdata.
It's still going to end up in the init region which is read/write in any
case, and still gets thrown away.
Given where we are, I don't think we need to rush this in during the
last week before the merge window opens, even though it's trivial.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-08-24 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 4:36 [PATCH 00/18] ARM: use const and __initconst for smp_operations Masahiro Yamada
2015-08-24 4:36 ` [PATCH 11/18] ARM: qcom: " Masahiro Yamada
2015-08-24 19:36 ` Andy Gross
2015-08-24 21:12 ` [PATCH 00/18] ARM: " Olof Johansson
2015-08-24 21:21 ` Russell King - ARM Linux [this message]
2015-08-24 21:44 ` Olof Johansson
2015-08-25 1:37 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150824212127.GH7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=agross@codeaurora.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=jason@lakedaemon.net \
--cc=jun.nie@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=soren.brinkmann@xilinx.com \
--cc=tsahee@annapurnalabs.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).