From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] firmware: qcom: scm: Add function stubs for ARM64 Date: Fri, 11 Sep 2015 18:56:49 +0100 Message-ID: <20150911175649.GZ21084@n2100.arm.linux.org.uk> References: <1441993856-30178-1-git-send-email-agross@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:41630 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbIKR44 (ORCPT ); Fri, 11 Sep 2015 13:56:56 -0400 Content-Disposition: inline In-Reply-To: <1441993856-30178-1-git-send-email-agross@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Andy Gross Cc: linux-arm-msm@vger.kernel.org, Mark Brown , Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Fri, Sep 11, 2015 at 12:50:56PM -0500, Andy Gross wrote: > This patch adds stubs for the SCM functions exposed in the QCOM SCM API. > > Signed-off-by: Andy Gross > --- > drivers/firmware/Makefile | 4 +++ > drivers/firmware/qcom_scm-64.c | 63 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 67 insertions(+) > create mode 100644 drivers/firmware/qcom_scm-64.c > > diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile > index 4a4b897..2f810c2 100644 > --- a/drivers/firmware/Makefile > +++ b/drivers/firmware/Makefile > @@ -12,8 +12,12 @@ obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o > obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o > obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o > obj-$(CONFIG_QCOM_SCM) += qcom_scm.o > +ifdef CONFIG_ARM64 > +obj-$(CONFIG_QCOM_SCM) += qcom_scm-64.o > +else > obj-$(CONFIG_QCOM_SCM) += qcom_scm-32.o > CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1) > +endif Can we not start doing stuff like this. Use the Kconfig to control what you build, not the Makefile system. config QCOM_SCM_32 def_bool y depends on QCOM_SCM && ARM config QCOM_SCM_64 def_bool y depends on QCOM_SCM && ARM64 and then use those in the makefile. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.