From: Stephen Boyd <sboyd@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 2/4] clk: qcom: Add support for RCGs with shared branches
Date: Wed, 16 Sep 2015 15:07:22 -0700 [thread overview]
Message-ID: <20150916220722.GM23081@codeaurora.org> (raw)
In-Reply-To: <1442409888-19917-3-git-send-email-georgi.djakov@linaro.org>
On 09/16, Georgi Djakov wrote:
> +static int clk_rcg2_shared_enable(struct clk_hw *hw)
> +{
> + struct clk_rcg2 *rcg = to_clk_rcg2(hw);
> +
> + if (!rcg->current_freq) {
> + struct clk_hw *parent = clk_hw_get_parent(hw);
> + unsigned long parent_rate = clk_hw_get_rate(parent);
> +
> + rcg->current_freq = clk_rcg2_recalc_rate(hw, parent_rate);
Hmm no. I meant adding a recal_rate implementation for this
specific type of clk_ops that assigns the current_freq value when
it's called. I assume we're not calling enable on this clock
before we register it with the framework.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-09-16 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:24 [PATCH v4 0/4] Add support for more MSM8916 clocks Georgi Djakov
2015-09-16 13:24 ` [PATCH v4 1/4] clk: qcom: Add MSM8916 iommu clocks Georgi Djakov
2015-09-16 13:24 ` [PATCH v4 2/4] clk: qcom: Add support for RCGs with shared branches Georgi Djakov
2015-09-16 22:07 ` Stephen Boyd [this message]
2015-09-16 13:24 ` [PATCH v4 3/4] clk: qcom: Add MSM8916 gpu clocks Georgi Djakov
2015-09-16 13:24 ` [PATCH v4 4/4] clk: qcom: Add MSM8916 audio clocks Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916220722.GM23081@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).