From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH v2 5/8] soc: qcom: smd: Remove use of VLAIS Date: Tue, 22 Sep 2015 10:34:56 -0500 Message-ID: <20150922153456.GA28017@qualcomm.com> References: <1441234011-4259-1-git-send-email-sboyd@codeaurora.org> <1441234011-4259-6-git-send-email-sboyd@codeaurora.org> <20150922011651.GQ13472@usrtlx11787.corpusers.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38990 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbIVPe6 (ORCPT ); Tue, 22 Sep 2015 11:34:58 -0400 Content-Disposition: inline In-Reply-To: <20150922011651.GQ13472@usrtlx11787.corpusers.net> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Stephen Boyd , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On Mon, Sep 21, 2015 at 06:16:51PM -0700, Bjorn Andersson wrote: > On Wed 02 Sep 15:46 PDT 2015, Stephen Boyd wrote: > > > Usage of VLAIS prevents clang from compiling this file, and it > > also opens us to the possibility of allocating a large structure > > on the stack to the point that we blow past the limit of the > > kernel stack. Remove the VLAIS and allocate a structure on the > > heap with kmalloc so that we're safer and more clang friendly. > > > [..] > > diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c > [..] > > struct { > > struct qcom_rpm_header hdr; > > struct qcom_rpm_request req; > > - u8 payload[count]; > > - } pkt; > > + u8 payload[]; > > + } *pkt; > > + size_t size = sizeof(*pkt) + count; > > > [..] > > > > - ret = qcom_smd_send(rpm->rpm_channel, &pkt, sizeof(pkt)); > > + ret = qcom_smd_send(rpm->rpm_channel, pkt, sizeof(*pkt)); > > It would be good if we actually include the request in the packet and > not just the headers :) > > s/sizeof(*pkt)/size/ > > Sorry for not spotting this before, made my device not boot now that it > showed up in linux-next. And oddly the 8974 RPM seems to just ack the > messages, without any indication of the request being truncated... > > > @Andy, I presume this is only on your -next, can you update the commit? > Or do you want a patch for it? I can fix it up. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project