From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [Patch v2 06/10] regulators: qcom-smd: Add PM8916 support Date: Wed, 23 Sep 2015 13:14:54 -0500 Message-ID: <20150923181454.GA24756@qualcomm.com> References: <1443027209-19444-1-git-send-email-agross@codeaurora.org> <1443027209-19444-7-git-send-email-agross@codeaurora.org> <20150923172358.GE24668@usrtlx11787.corpusers.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60242 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbbIWSO6 (ORCPT ); Wed, 23 Sep 2015 14:14:58 -0400 Content-Disposition: inline In-Reply-To: <20150923172358.GE24668@usrtlx11787.corpusers.net> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: "linux-arm-msm@vger.kernel.org" , Mark Brown , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On Wed, Sep 23, 2015 at 10:23:58AM -0700, Bjorn Andersson wrote: > On Wed 23 Sep 09:53 PDT 2015, Andy Gross wrote: > > > This patch adds support and documentation for the PM8916 regulators > > found on MSM8916 platforms. > > > > Signed-off-by: Andy Gross > > --- > > .../bindings/soc/qcom/qcom,smd-rpm-regulator.txt | 18 ++++++ > > drivers/regulator/qcom_smd-regulator.c | 64 ++++++++++++++++++++ > > 2 files changed, 82 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > > index 7084474..05dfc1a 100644 > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm-regulator.txt > > @@ -18,6 +18,7 @@ Regulator nodes are identified by their compatible: > > Definition: must be one of: > > "qcom,rpm-pm8841-regulators" > > "qcom,rpm-pm8941-regulators" > > + "qcom,rpm-pm8916-regulators" > > Alphabetical please > > > > > - vdd_s1-supply: > > - vdd_s2-supply: > > @@ -50,6 +51,19 @@ Regulator nodes are identified by their compatible: > > Definition: reference to regulator supplying the input pin, as > > described in the data sheet > > > > +- vdd_s1-supply: > > +- vdd_s2-supply: > > +- vdd_s3-supply: > > +- vdd_s4-supply: > > +- vdd_l1_l2_l3-supply > > +- vdd_l4_l5_l6-supply > > +- vdd_l7-supply > > End these with ':' as well > > > +- vdd_l8_l9_l10_l11_l12_l13_l14_l15_l16_l17_l18-supply: > > + Usage: optional (pm8916 only) > > + Value type: > > + Definition: reference to regulator supplying the input pin, as > > + described in the data sheet > > + > [..] > > diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c > [..] > > static const struct of_device_id rpm_of_match[] = { > > + { .compatible = "qcom,rpm-pm8916-regulators", .data = &rpm_pm8916_regulators }, > > pm8916 > pm8841 > > > { .compatible = "qcom,rpm-pm8841-regulators", .data = &rpm_pm8841_regulators }, > > { .compatible = "qcom,rpm-pm8941-regulators", .data = &rpm_pm8941_regulators }, > > {} > > With these nits: > > Acked-by: Bjorn Andersson > > Regards, > Bjorn I'll fixup this when I apply it. Thanks! -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project