From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH/RESEND] ARM: Remove __ref on hotplug cpu die path Date: Mon, 19 Oct 2015 21:23:01 +0100 Message-ID: <20151019202301.GA453@leverpostej> References: <1445285133-11977-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from foss.arm.com ([217.140.101.70]:51929 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531AbbJSUXN (ORCPT ); Mon, 19 Oct 2015 16:23:13 -0400 Content-Disposition: inline In-Reply-To: <1445285133-11977-1-git-send-email-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: arm@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Shiraz Hashim , Stephen Warren , Alexandre Courbot , Lorenzo Pieralisi , Will Deacon , linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, spear-devel@list.st.com, linux-tegra@vger.kernel.org On Mon, Oct 19, 2015 at 01:05:33PM -0700, Stephen Boyd wrote: > Now that __cpuinit has been removed, the __ref markings on these > functions are useless. Remove them. This also reduces the size of > the multi_v7_defconfig image: > > $ size before after > text data bss dec hex filename > 12683578 1470996 348904 14503478 dd4e36 before > 12683274 1470996 348904 14503174 dd4d06 after > > presumably because now we don't have to jump to code in the > .ref.text section and/or the noinline marking is removed. FWIW: Acked-by: Mark Rutland Mark. > Cc: Tony Lindgren > Acked-by: Barry Song > Acked-by: Andy Gross > Acked-by: Viresh Kumar > Cc: Shiraz Hashim > Cc: Stephen Warren > Acked-by: Thierry Reding > Cc: Alexandre Courbot > Acked-by: Linus Walleij > Acked-by: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Will Deacon > Cc: Mark Rutland > Cc: > Cc: > Cc: > Cc: > Signed-off-by: Stephen Boyd > --- > > Collected the acks and resent. > > arch/arm/kernel/psci_smp.c | 4 ++-- > arch/arm/mach-omap2/omap-hotplug.c | 2 +- > arch/arm/mach-omap2/omap-wakeupgen.c | 2 +- > arch/arm/mach-prima2/hotplug.c | 2 +- > arch/arm/mach-qcom/platsmp.c | 2 +- > arch/arm/mach-realview/hotplug.c | 2 +- > arch/arm/mach-spear/hotplug.c | 2 +- > arch/arm/mach-tegra/hotplug.c | 2 +- > arch/arm/mach-ux500/hotplug.c | 2 +- > arch/arm/mach-vexpress/hotplug.c | 2 +- > 10 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c > index 61c04b02faeb..9d479b2ea40d 100644 > --- a/arch/arm/kernel/psci_smp.c > +++ b/arch/arm/kernel/psci_smp.c > @@ -71,7 +71,7 @@ int psci_cpu_disable(unsigned int cpu) > return 0; > } > > -void __ref psci_cpu_die(unsigned int cpu) > +void psci_cpu_die(unsigned int cpu) > { > u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN << > PSCI_0_2_POWER_STATE_TYPE_SHIFT; > @@ -83,7 +83,7 @@ void __ref psci_cpu_die(unsigned int cpu) > panic("psci: cpu %d failed to shutdown\n", cpu); > } > > -int __ref psci_cpu_kill(unsigned int cpu) > +int psci_cpu_kill(unsigned int cpu) > { > int err, i; > > diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c > index 971791fe9a3f..593fec753b28 100644 > --- a/arch/arm/mach-omap2/omap-hotplug.c > +++ b/arch/arm/mach-omap2/omap-hotplug.c > @@ -27,7 +27,7 @@ > * platform-specific code to shutdown a CPU > * Called with IRQs disabled > */ > -void __ref omap4_cpu_die(unsigned int cpu) > +void omap4_cpu_die(unsigned int cpu) > { > unsigned int boot_cpu = 0; > void __iomem *base = omap_get_wakeupgen_base(); > diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c > index db7e0bab3587..2da0d974f2f7 100644 > --- a/arch/arm/mach-omap2/omap-wakeupgen.c > +++ b/arch/arm/mach-omap2/omap-wakeupgen.c > @@ -330,7 +330,7 @@ static int irq_cpu_hotplug_notify(struct notifier_block *self, > return NOTIFY_OK; > } > > -static struct notifier_block __refdata irq_hotplug_notifier = { > +static struct notifier_block irq_hotplug_notifier = { > .notifier_call = irq_cpu_hotplug_notify, > }; > > diff --git a/arch/arm/mach-prima2/hotplug.c b/arch/arm/mach-prima2/hotplug.c > index 0ab2f8bae28e..a728c78b996f 100644 > --- a/arch/arm/mach-prima2/hotplug.c > +++ b/arch/arm/mach-prima2/hotplug.c > @@ -32,7 +32,7 @@ static inline void platform_do_lowpower(unsigned int cpu) > * > * Called with IRQs disabled > */ > -void __ref sirfsoc_cpu_die(unsigned int cpu) > +void sirfsoc_cpu_die(unsigned int cpu) > { > platform_do_lowpower(cpu); > } > diff --git a/arch/arm/mach-qcom/platsmp.c b/arch/arm/mach-qcom/platsmp.c > index 5cde63a64b34..9b00123a315d 100644 > --- a/arch/arm/mach-qcom/platsmp.c > +++ b/arch/arm/mach-qcom/platsmp.c > @@ -49,7 +49,7 @@ extern void secondary_startup_arm(void); > static DEFINE_SPINLOCK(boot_lock); > > #ifdef CONFIG_HOTPLUG_CPU > -static void __ref qcom_cpu_die(unsigned int cpu) > +static void qcom_cpu_die(unsigned int cpu) > { > wfi(); > } > diff --git a/arch/arm/mach-realview/hotplug.c b/arch/arm/mach-realview/hotplug.c > index ac22dd41b135..968e2d1964f6 100644 > --- a/arch/arm/mach-realview/hotplug.c > +++ b/arch/arm/mach-realview/hotplug.c > @@ -90,7 +90,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > * > * Called with IRQs disabled > */ > -void __ref realview_cpu_die(unsigned int cpu) > +void realview_cpu_die(unsigned int cpu) > { > int spurious = 0; > > diff --git a/arch/arm/mach-spear/hotplug.c b/arch/arm/mach-spear/hotplug.c > index d97749c642ce..12edd1cf8a12 100644 > --- a/arch/arm/mach-spear/hotplug.c > +++ b/arch/arm/mach-spear/hotplug.c > @@ -80,7 +80,7 @@ static inline void spear13xx_do_lowpower(unsigned int cpu, int *spurious) > * > * Called with IRQs disabled > */ > -void __ref spear13xx_cpu_die(unsigned int cpu) > +void spear13xx_cpu_die(unsigned int cpu) > { > int spurious = 0; > > diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c > index 6fc71f1534b0..1b129899a277 100644 > --- a/arch/arm/mach-tegra/hotplug.c > +++ b/arch/arm/mach-tegra/hotplug.c > @@ -37,7 +37,7 @@ int tegra_cpu_kill(unsigned cpu) > * > * Called with IRQs disabled > */ > -void __ref tegra_cpu_die(unsigned int cpu) > +void tegra_cpu_die(unsigned int cpu) > { > if (!tegra_hotplug_shutdown) { > WARN(1, "hotplug is not yet initialized\n"); > diff --git a/arch/arm/mach-ux500/hotplug.c b/arch/arm/mach-ux500/hotplug.c > index 2bc00b085e38..1cbed0331fd3 100644 > --- a/arch/arm/mach-ux500/hotplug.c > +++ b/arch/arm/mach-ux500/hotplug.c > @@ -21,7 +21,7 @@ > * > * Called with IRQs disabled > */ > -void __ref ux500_cpu_die(unsigned int cpu) > +void ux500_cpu_die(unsigned int cpu) > { > /* directly enter low power state, skipping secure registers */ > for (;;) { > diff --git a/arch/arm/mach-vexpress/hotplug.c b/arch/arm/mach-vexpress/hotplug.c > index f0ce6b8f5e71..f2fafc10a91d 100644 > --- a/arch/arm/mach-vexpress/hotplug.c > +++ b/arch/arm/mach-vexpress/hotplug.c > @@ -85,7 +85,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) > * > * Called with IRQs disabled > */ > -void __ref vexpress_cpu_die(unsigned int cpu) > +void vexpress_cpu_die(unsigned int cpu) > { > int spurious = 0; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >