From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Date: Thu, 19 Nov 2015 00:04:26 -0600 Message-ID: <20151119060426.GA22622@qualcomm.com> References: <1447808426-21834-1-git-send-email-sboyd@codeaurora.org> <1447875197-21645-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1447875197-21645-1-git-send-email-sboyd@codeaurora.org> Sender: linux-gpio-owner@vger.kernel.org To: Stephen Boyd Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, "Ivan T. Ivanov" , Bjorn Andersson List-Id: linux-arm-msm@vger.kernel.org On Wed, Nov 18, 2015 at 11:33:17AM -0800, Stephen Boyd wrote: > The number of interrupts is always equal to the number of pins > provided by the PMIC gpio and MPP hardware blocks. Count the > number of irqs to figure out the number of pins instead of adding > more compatible strings or doing math on the reg property. This > should make the code more generic and ease the number of changes > we have to make to the driver for each new pmic revision. > > Cc: "Ivan T. Ivanov" > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- This is pretty nice. Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project