From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v4 4/5] clk: qcom: Add RPM clock controller driver Date: Sat, 21 Nov 2015 18:18:20 -0800 Message-ID: <20151122021820.GK30882@usrtlx11787.corpusers.net> References: <1447941480-27487-1-git-send-email-georgi.djakov@linaro.org> <1447941480-27487-5-git-send-email-georgi.djakov@linaro.org> <20151121003953.GD28998@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from seldrel01.sonyericsson.com ([37.139.156.2]:3729 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbbKVCS0 (ORCPT ); Sat, 21 Nov 2015 21:18:26 -0500 Content-Disposition: inline In-Reply-To: <20151121003953.GD28998@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Georgi Djakov , "agross@codeaurora.org" , "mturquette@baylibre.com" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" On Fri 20 Nov 16:39 PST 2015, Stephen Boyd wrote: > On 11/19, Georgi Djakov wrote: > > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > new file mode 100644 > > index 000000000000..bd0fd0cd50dc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.txt > > @@ -0,0 +1,35 @@ > > +Qualcomm RPM Clock Controller Binding > > +------------------------------------------------ > > +The RPM is a dedicated hardware engine for managing the shared > > +SoC resources in order to keep the lowest power profile. It > > +communicates with other hardware subsystems via shared memory > > +and accepts clock requests, aggregates the requests and turns > > +the clocks on/off or scales them on demand. > > + > > +Required properties : > > +- compatible : shall contain only one of the following: > > + > > + "qcom,rpmcc-msm8916" > > We need to add qcom,rpmcc as a generic compatible as well. > The binding is generic and the clock defines global, so this should work fine on the dt side of things. But how do we implement this? Which set of clocks does the generic rpmcc actually provide? Do you foresee that there will be an implementation of the generic rpmcc or is it just a way to "standardize" the dt binding? Regards, Bjorn