From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] ARM: qcom: select ARM_CPU_SUSPEND for power management Date: Wed, 25 Nov 2015 15:06:40 -0600 Message-ID: <20151125210640.GA5643@Agamemnon.attlocal.net> References: <5497046.7sx8fEMiNf@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60194 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbbKYVGn (ORCPT ); Wed, 25 Nov 2015 16:06:43 -0500 Content-Disposition: inline In-Reply-To: <5497046.7sx8fEMiNf@wuerfel> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Arnd Bergmann Cc: Kumar Gala , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lina Iyer , Stephen Boyd On Tue, Nov 24, 2015 at 11:13:09PM +0100, Arnd Bergmann wrote: > The qcom spm driver uses cpu_resume_arm(), which is not included > in the kernel in all configurations: > > drivers/built-in.o: In function `qcom_cpu_spc': > :(.text+0xbc022): undefined reference to `cpu_suspend' > drivers/built-in.o: In function `qcom_cpuidle_init': > :(.init.text+0x610c): undefined reference to `cpu_resume_arm' > > This adds a 'select' Kconfig statement to ensure it's always > enabled. > > Signed-off-by: Arnd Bergmann > --- > This has been broken for a while but not even shown up in many thousands of > randconfig builds until today. Please queue it up for 4.5 unless you think > it should really go into 4.4 as well. Thanks Arnd. I'll add this to my list for the pull request.