Re: [PATCH v4 3/3] ARM: dts: qcom: add charger otg regulator

Bjorn Andersson
2015-12-15T22:09:21Z

On Tue 15 Dec 11:52 PST 2015, Tim Bird wrote:

> Add the otg regulator provided by the charger block.
>
> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
> ---
> Changes since V3:
> - change name of charger regulator to "otg-vbus"
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index b0d4439..d0ffca7 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -45,6 +45,10 @@
> "chg-gone",
> "usb-valid",
> "dc-valid";
> +
> + usb_otg_in-supply = <&pm8941_5vs1>;

Although this could be coming from some other supply I think it's
perfectly fine that we define this on a platform level.

> +
> + chg_otg: otg-vbus { };
> };
>
> pm8941_gpios: gpios@c000 {

Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Regards,
Bjorn