From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH] drivers: qcom: spm: avoid module usage in non-modular SPM driver Date: Mon, 4 Jan 2016 12:30:12 -0500 Message-ID: <20160104173012.GM12458@windriver.com> References: <1451927725-7257-1-git-send-email-lina.iyer@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail1.windriver.com ([147.11.146.13]:64404 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbcADRaQ (ORCPT ); Mon, 4 Jan 2016 12:30:16 -0500 Content-Disposition: inline In-Reply-To: <1451927725-7257-1-git-send-email-lina.iyer@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Lina Iyer Cc: andy.gross@linaro.org, sboyd@codeaurora.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org [[PATCH] drivers: qcom: spm: avoid module usage in non-modular SPM driver] On 04/01/2016 (Mon 10:15) Lina Iyer wrote: > SPM driver provides cpuidle support on some QC SoC's. The functionality > is non-modular and there is no need for module support. Convert module > platform init to builtin platform driver init. The driver functionality > is not affected by this change. > > Cc: Paul Gortmaker I have a similar patch locally that I'd not sent yet, the only difference is that I moved the description tag to the top of the file since there wasn't a description therei, i.e. this chunk: diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c index b04b05a0904e..9e06a241257f 100644 --- a/drivers/soc/qcom/spm.c +++ b/drivers/soc/qcom/spm.c @@ -2,6 +2,8 @@ * Copyright (c) 2011-2014, The Linux Foundation. All rights reserved. * Copyright (c) 2014,2015, Linaro Ltd. * + * SAW power controller driver + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and * only version 2 as published by the Free Software Foundation. Paul. -- > Signed-off-by: Lina Iyer > --- > drivers/soc/qcom/spm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/soc/qcom/spm.c b/drivers/soc/qcom/spm.c > index b04b05a..199c085 100644 > --- a/drivers/soc/qcom/spm.c > +++ b/drivers/soc/qcom/spm.c > @@ -12,7 +12,6 @@ > * GNU General Public License for more details. > */ > > -#include > #include > #include > #include > @@ -378,8 +377,4 @@ static struct platform_driver spm_driver = { > .of_match_table = spm_match_table, > }, > }; > -module_platform_driver(spm_driver); > - > -MODULE_LICENSE("GPL v2"); > -MODULE_DESCRIPTION("SAW power controller driver"); > -MODULE_ALIAS("platform:saw"); > +builtin_platform_driver(spm_driver); > -- > 2.1.4 >