From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: qcom-spmi-pmic: Don't access non-existing registers Date: Mon, 11 Jan 2016 05:50:00 +0000 Message-ID: <20160111055000.GK3331@x1> References: <1447805204-32483-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1447805204-32483-1-git-send-email-sboyd@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Boyd Cc: "Ivan T. Ivanov" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Tue, 17 Nov 2015, Stephen Boyd wrote: > From: "Ivan T. Ivanov" >=20 > Revision ID registers are available only on devices with > Slave IDs that are even, so don't make access to unavailable > registers. >=20 > Signed-off-by: Ivan T. Ivanov > [sboyd@codeaurora.org: Consider all slave ids that are even] > Signed-off-by: Stephen Boyd > --- > drivers/mfd/qcom-spmi-pmic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmi= c.c > index af6ac1c4b45c..8653e8b9bb4f 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -127,7 +127,9 @@ static int pmic_spmi_probe(struct spmi_device *sd= ev) > if (IS_ERR(regmap)) > return PTR_ERR(regmap); > =20 > - pmic_spmi_show_revid(regmap, &sdev->dev); > + /* Only the first slave id for a PMIC contains this information */ > + if (sdev->usid % 2 =3D=3D 0) > + pmic_spmi_show_revid(regmap, &sdev->dev); > =20 > return of_platform_populate(root, NULL, NULL, &sdev->dev); > } --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog