From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] regulator: qcom-saw2: Add support for SAW2 regulators Date: Fri, 29 Jan 2016 00:24:57 +0100 Message-ID: <20160128232457.GF4130@sirena.org.uk> References: <1453993142-17885-1-git-send-email-georgi.djakov@linaro.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0hHDr/TIsw4o3iPK" Return-path: Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51230 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbcA1XZK (ORCPT ); Thu, 28 Jan 2016 18:25:10 -0500 Content-Disposition: inline In-Reply-To: <1453993142-17885-1-git-send-email-georgi.djakov@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Georgi Djakov Cc: lgirdwood@gmail.com, andy.gross@linaro.org, lina.iyer@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org --0hHDr/TIsw4o3iPK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 28, 2016 at 04:59:02PM +0200, Georgi Djakov wrote: > +static int saw2_regulator_get_voltage(struct regulator_dev *rdev) > +{ > + struct saw2_vreg *vreg = rdev_get_drvdata(rdev); > + > + return regulator_list_voltage_linear_range(rdev, vreg->selector); > +} Implement regulator_get_voltage_sel() instead. > + do { > + regmap_read(vreg->regmap, SPM_REG_STS_1, &new_val); > + new_val &= 0xff; > + if (new_val == val) > + break; > + udelay(1); > + } while (--timeout_us); A cpu_relax() in here might be friendly. > + if (sel > vreg->selector) { > + /* PMIC internal slew rate is 1250 uV/us */ > + udelay((sel - vreg->selector) * 10); > + } The core already does this for you. > + vreg->rdesc.name = of_get_property(np, "regulator-name", NULL); Don't open code standard properties and don't add new use of legacy properties like regulator-name. Just assign a sensible name. --0hHDr/TIsw4o3iPK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWqqNHAAoJECTWi3JdVIfQ+BwH/1O2bboTN/VQP0bSaYN4Cp9K /OGvwkR3AFkJwvcZVYYOpBh8lTML4NrHqD7ZBqcCogK65AgNV91og0rYOK/LJpb+ c/dkmzvSbQW5c7/94HPgirzh9ADsHKF4bNyBw+ha/A4DO17Qi3k21JZH1iNaMJv2 r2xJs07ST4P5lKHaA86AgSAD0zWyhUpLBwbEYqlas5d7nektxnuGzJ4Ue6LY3GmZ 87A0PERb9x7KFg3SYaxFWblZmQpzM9LW5gWtHoM6XCxn8WyeSbFT3sLWAsgKUjUN qTztge4nUP596IjAfUIJvMkE8Tac5zXoWdZdwtpCaaQU2pnggkW1vmr5gWJYB6M= =73xh -----END PGP SIGNATURE----- --0hHDr/TIsw4o3iPK--