From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Westfield Subject: Re: [alsa-devel] [PATCH RFC 00/15] ASoC: qcom: Add capture support. Date: Tue, 2 Feb 2016 16:33:10 -0800 Message-ID: <20160203003310.GA14436@kwestfie-linux.qualcomm.com> References: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36170 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbcBCAdN (ORCPT ); Tue, 2 Feb 2016 19:33:13 -0500 Content-Disposition: inline In-Reply-To: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: Patrick Lai , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown On Mon, Feb 01, 2016 at 09:27:02AM -0800, Srinivas Kandagatla wrote: > LPASS IP on QCOM SOC supports both Playback and capture > via I2S, but this feature is missing in existing code. > This patchset aims at adding capture support to lpass IP. > First few patches in this series does cleanup the driver > to make easy to add capture support. > > These patches are tested on DB410C with Headset Mic. Thanks for posting this. I went through the changes, and it mostly looks good minus some small, easy-to-fix nits. -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project