From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Welling <mwelling@ieee.org>
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
Date: Wed, 17 Feb 2016 17:53:14 -0600
Message-ID: <20160217235314.GA13145@deathstar>
References: <CAEnQRZAjgn3Y0618MgO284DMc_9cE49b9jeUr0j2HwUK6YK+0A@mail.gmail.com>
 <20160206003245.GA1329@deathstar>
 <20160208102459.GC2220@tetsubishi>
 <20160208163632.GA3630@deathstar>
 <01fd01d162a4$8e28c450$aa7a4cf0$@codeaurora.org>
 <20160208191658.GA23145@deathstar>
 <001b01d163fd$bfb15280$3f13f780$@codeaurora.org>
 <CAEnQRZCzkq5wFsS7Ydby+bsFJTbGVq=AX9TLkkhfMKOG8gAZHA@mail.gmail.com>
 <003201d16415$0eb1a8f0$2c14fad0$@codeaurora.org>
 <20160210163622.GA1390@deathstar>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-ig0-f175.google.com ([209.85.213.175]:37396 "EHLO
	mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161084AbcBQXx3 (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Wed, 17 Feb 2016 18:53:29 -0500
Content-Disposition: inline
In-Reply-To: <20160210163622.GA1390@deathstar>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Sricharan <sricharan@codeaurora.org>
Cc: 'Daniel Baluta' <daniel.baluta@intel.com>, 'Wolfram Sang' <wsa@the-dreams.de>, 'Jonathan Cameron' <jic23@kernel.org>, 'Hartmut Knaack' <knaack.h@gmx.de>, 'Lars-Peter Clausen' <lars@metafoo.de>, 'Peter Meerwald-Stadler' <pmeerw@pmeerw.net>, 'Linux Kernel Mailing List' <linux-kernel@vger.kernel.org>, linux-iio@vger.kernel.org, 'Lucas De Marchi' <lucas.demarchi@intel.com>, 'Andy Gross' <agross@codeaurora.org>, 'Pramod Gurav' <pramod.gurav@smartplayin.com>, 'Bjorn Andersson' <bjorn.andersson@sonymobile.com>, 'Guenter Roeck' <linux@roeck-us.net>, eibach@gdsys.de, linux-arm-msm@vger.kernel.org

On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote:
> On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote:
> > > Hi Sricharan,
> > >=20
> > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c
> > > right?
> > >
> >  Yes.
> > =20
> > > I'm asking this because this driver doesn't seem to support runti=
me pm and
> > > there is no check for regmap_write/regmap_write return code in th=
e probe
> > > function.
> >    Hmm to be clear, so it=E2=80=99s the pm_runtime_getsync from i2c=
-qup which fails right ?
> >    I was tracking that when there are i2c_xfers from pwm. I did not=
 see any failures there.
> >    So wanted to know the correct sequence to reproduce.
> >
>=20
> The problem was discovered using the patch that this thread is on. Th=
e PWM driver does
> not have the problem.
>=20
> When the driver in this patch called pm_runtime_get_sync you got -EIN=
VAL back.

I noticed some patches for the QUP I2C driver in linux-next so I built =
against it.

The ADC driver now appears to work as desired.

root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_volta=
ge0_raw=20
287
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_volta=
ge1_raw=20
269
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_volta=
ge2_raw=20
270
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_volta=
ge3_raw=20
271

>=20
> > Regards,
> >   Sricharan
> >  =20
> >=20
> >=20