Re: [PATCH] clk: qcom: Fix pre-divider usage for pixel RCG

[Stephen Boyd <sboyd@codeaurora.org>]

On 02/26, Archit Taneja wrote:
> diff --git a/drivers/clk/qcom/clk-rcg.c b/drivers/clk/qcom/clk-rcg.c
> index bfbb28f..2c033f2 100644
> --- a/drivers/clk/qcom/clk-rcg.c
> +++ b/drivers/clk/qcom/clk-rcg.c
> @@ -655,8 +654,13 @@ static int clk_rcg_pixel_set_rate(struct clk_hw *hw, unsigned long rate,
>  			(parent_rate > (request + delta)))
>  			continue;
>  
> -		f.m = frac->num;
> -		f.n = frac->den;
> +		/* try to use only the pre-divider if we can */
> +		if (frac->num == 1) {
> +			f.pre_div = frac->den;

What if the pre divider can't support the frac->den value? Maybe
we should just force the pre divider to be in bypass so that we
can use the m/n all the time.

> +		} else {
> +			f.m = frac->num;
> +			f.n = frac->den;
> +		}
>  
>  		return __clk_rcg_set_rate(rcg, &f);
>  	}

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project