From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops Date: Wed, 20 Apr 2016 09:40:10 +0100 Message-ID: <20160420084010.GB3824@red-moon> References: <1458657763-2561-1-git-send-email-jszhang@marvell.com> <1458657763-2561-5-git-send-email-jszhang@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from foss.arm.com ([217.140.101.70]:45192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbcDTIkQ (ORCPT ); Wed, 20 Apr 2016 04:40:16 -0400 Content-Disposition: inline In-Reply-To: <1458657763-2561-5-git-send-email-jszhang@marvell.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jisheng Zhang Cc: linux@arm.linux.org.uk, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org On Tue, Mar 22, 2016 at 10:42:43PM +0800, Jisheng Zhang wrote: > The psci_cpuidle_ops structures is not over-written, so add "const" > qualifier and replace __initdata with __initconst. > > Signed-off-by: Jisheng Zhang > --- > drivers/firmware/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Lorenzo Pieralisi > diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c > index 6d86881..7d52186 100644 > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -355,7 +355,7 @@ int psci_cpu_suspend_enter(unsigned long index) > > /* ARM specific CPU idle operations */ > #ifdef CONFIG_ARM > -static struct cpuidle_ops psci_cpuidle_ops __initdata = { > +static const struct cpuidle_ops psci_cpuidle_ops __initconst = { > .suspend = psci_cpu_suspend_enter, > .init = psci_dt_cpu_init_idle, > }; > -- > 2.8.0.rc3 >