From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH v1 1/3] regulator: helpers: consider constriants in list_voltage_linear_range
Date: Thu, 2 Jun 2016 12:05:57 +0100 [thread overview]
Message-ID: <20160602110557.GH2282@sirena.org.uk> (raw)
In-Reply-To: <1464862996-3147-2-git-send-email-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Thu, Jun 02, 2016 at 11:23:14AM +0100, Srinivas Kandagatla wrote:
> Regulator drivers can have linear range which is according to the
> regualtor hardware spec, however the board level device tree files
> can restrict this range by adding constriants.
> These constriants are not considered in the exsiting code, which
> gives false supported voltage range to the consumers.
...
> For now I have added this support for regulator_list_voltage_linear_range()
> If it makes sense we can extend this to other list voltage helpers too.
Why are you making this change? The obvious problem here is that drivers
should not be looking at constraints - it would be silly to duplicate
constraint enforcing code in individual drivers and would lead to
inconsistent performance of constraints. This is why we do this in the
core, in _regulator_list_voltage(), which means that if this change has
any effect there's something else going on that needs to be
investigated.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-02 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 10:23 [RFC PATCH v1 0/3] regulator: qcom_smd: add list_voltage callback support Srinivas Kandagatla
2016-06-02 10:23 ` [RFC PATCH v1 1/3] regulator: helpers: consider constriants in list_voltage_linear_range Srinivas Kandagatla
2016-06-02 11:05 ` Mark Brown [this message]
2016-06-02 11:53 ` Srinivas Kandagatla
2016-06-02 10:23 ` [RFC PATCH v1 2/3] regulator: qcom_smd: add list_voltage callback Srinivas Kandagatla
2016-06-03 10:40 ` Mark Brown
2016-06-03 11:24 ` Srinivas Kandagatla
2016-06-13 15:48 ` Applied "regulator: qcom_smd: add list_voltage callback" to the regulator tree Mark Brown
2016-06-02 10:23 ` [RFC PATCH v1 3/3] regulator: qcom_smd: add linear range to pm8941 lnldo Srinivas Kandagatla
2016-06-02 14:49 ` Mark Brown
2016-06-02 14:57 ` Srinivas Kandagatla
2016-06-02 15:50 ` Mark Brown
2016-06-02 16:04 ` Bjorn Andersson
2016-06-02 16:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602110557.GH2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).