From: Peter Zijlstra <peterz@infradead.org>
To: Neil Leeder <nleeder@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Timur Tabi <timur@codeaurora.org>,
Mark Salter <msalter@redhat.com>,
WillDeacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
cov@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] perf: allow add to change event state
Date: Fri, 3 Jun 2016 23:38:29 +0200 [thread overview]
Message-ID: <20160603213829.GD3710@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1464987812-14360-2-git-send-email-nleeder@codeaurora.org>
On Fri, Jun 03, 2016 at 05:03:31PM -0400, Neil Leeder wrote:
> When the platform-specific pmu->add function returns
> an error, it may have also changed the event's state.
> If so, do not override that new state.
This is inadequate; it fails to what the problem is and why this is a
good solution.
next prev parent reply other threads:[~2016-06-03 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 21:03 [PATCH 0/2] qcom: add l2 cache perf events driver Neil Leeder
2016-06-03 21:03 ` [PATCH 1/2] perf: allow add to change event state Neil Leeder
2016-06-03 21:38 ` Peter Zijlstra [this message]
2016-06-03 21:03 ` [PATCH 2/2] soc: qcom: add l2 cache perf events driver Neil Leeder
2016-06-06 9:51 ` Mark Rutland
2016-06-08 15:16 ` Neil Leeder
2016-06-09 15:56 ` Mark Rutland
2016-06-09 19:41 ` Peter Zijlstra
2016-06-10 22:34 ` Neil Leeder
2016-06-06 9:04 ` [PATCH 0/2] " Mark Rutland
2016-06-08 15:21 ` Neil Leeder
2016-06-08 16:12 ` Mark Rutland
2016-06-08 19:29 ` Neil Leeder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603213829.GD3710@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mlangsdo@redhat.com \
--cc=msalter@redhat.com \
--cc=nleeder@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).