From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 1/2] perf: allow add to change event state Date: Fri, 3 Jun 2016 23:38:29 +0200 Message-ID: <20160603213829.GD3710@twins.programming.kicks-ass.net> References: <1464987812-14360-1-git-send-email-nleeder@codeaurora.org> <1464987812-14360-2-git-send-email-nleeder@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1464987812-14360-2-git-send-email-nleeder@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Neil Leeder Cc: Mark Rutland , Mark Langsdorf , Jon Masters , Catalin Marinas , Timur Tabi , Mark Salter , WillDeacon , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , cov@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Fri, Jun 03, 2016 at 05:03:31PM -0400, Neil Leeder wrote: > When the platform-specific pmu->add function returns > an error, it may have also changed the event's state. > If so, do not override that new state. This is inadequate; it fails to what the problem is and why this is a good solution.