From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] tty: serial: msm: fix definition of msm_stop_dma Date: Thu, 9 Jun 2016 14:21:01 -0500 Message-ID: <20160609192101.GK13357@hector.attlocal.net> References: <1465323112-32366-1-git-send-email-ben.dooks@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-oi0-f42.google.com ([209.85.218.42]:34667 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbcFITVF (ORCPT ); Thu, 9 Jun 2016 15:21:05 -0400 Received: by mail-oi0-f42.google.com with SMTP id e72so79147045oib.1 for ; Thu, 09 Jun 2016 12:21:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1465323112-32366-1-git-send-email-ben.dooks@codethink.co.uk> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, David Brown , Greg Kroah-Hartman , Jiri Slaby , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Tue, Jun 07, 2016 at 07:11:52PM +0100, Ben Dooks wrote: > The msm_stop_dma() is not exported from the driver, so make > it static to stop the following warning: > > drivers/tty/serial/msm_serial.c:84:6: warning: symbol 'msm_stop_dma' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Good find. Acked-by: Andy Gross