From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 1/8] arm64: dts: db820c: add basic board support Date: Tue, 21 Jun 2016 21:49:16 -0700 Message-ID: <20160622044916.GF1256@tuxbot> References: <1466529769-2674-1-git-send-email-srinivas.kandagatla@linaro.org> <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f182.google.com ([209.85.192.182]:33841 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750809AbcFVEtU (ORCPT ); Wed, 22 Jun 2016 00:49:20 -0400 Received: by mail-pf0-f182.google.com with SMTP id h14so13639710pfe.1 for ; Tue, 21 Jun 2016 21:49:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1466529769-2674-2-git-send-email-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Srinivas Kandagatla Cc: Andy Gross , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Rob Herring , linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Tue 21 Jun 10:22 PDT 2016, Srinivas Kandagatla wrote: [..] > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts [..] > + > +/ { > + model = "Qualcomm Technologies, Inc. DB820c"; > + compatible = "qcom,apq8096-sbc"; I'm still not buying the concept of this being the one and only single-board-computer. If this compatible fully and exclusively identifies this particular board then dtbTool should be updated to follow the product name "qcom,apq8096-db820c". If on the other hand this identifies a class of single-board-computers, then the compatible should list both "qcom,apq8096-dtb820c" and "qcom,apq8096-sbc". Further more, the ePAPR defines this property as: "Specifies a list of platform architectures with which this platform is compatible. This property can be used by operating systems in selecting platform specific code." So I think we should follow the common pattern of having the least significant entry being "qcom,apq8096". > +}; Regards, Bjorn