From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH] pinctrl: qcom: establish proper EBI2 pin groups Date: Fri, 8 Jul 2016 12:20:58 -0500 Message-ID: <20160708172058.GA7896@hector.attlocal.net> References: <1467933329-2854-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-oi0-f42.google.com ([209.85.218.42]:35294 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbcGHRVE (ORCPT ); Fri, 8 Jul 2016 13:21:04 -0400 Received: by mail-oi0-f42.google.com with SMTP id r2so67377076oih.2 for ; Fri, 08 Jul 2016 10:21:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1467933329-2854-1-git-send-email-linus.walleij@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Bjorn Andersson , Stephen Boyd , David Brown On Fri, Jul 08, 2016 at 01:15:29AM +0200, Linus Walleij wrote: > After some digging around I found documentation (!) of the APQ8060 > EBI2 pin groups. It turns out I first need to split the group in > two: ebi2cs and ebi2 proper. The chip select pins are kind of > orthogonal to the other EBI2 pins since CS1B and CS2B can be muxed > over address bits 7 and 6 (don't know why, but they can). This > is good to fix up before we add users. >=20 > Also found what the "holes" in the assignment all the way up to > gpio158 was actually for. >=20 > All mux documentation comes from "Snapdragon(TM) S3 APQ8060-based > DragonBoard(TM) GPIO User Guide Rev. E August 10, 2012", published > by Bsquare Corporation. >=20 > As the documentation seems a bit hard to come by I put some comments > in the group definitions so that it is clear to all readers what > is going on here and what the lines are used for. >=20 > Cc: Bj=F6rn Andersson > Cc: Stephen Boyd > Signed-off-by: Linus Walleij > --- Seems reasonable. I'd presume the Documentation needs updating too for= the new groups. Reviewed-by: Andy Gross