From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Date: Mon, 11 Jul 2016 17:38:27 -0500 Message-ID: <20160711223827.GA6053@hector.attlocal.net> References: <20160711215009.4519-1-sboyd@codeaurora.org> <20160711215009.4519-3-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-oi0-f48.google.com ([209.85.218.48]:32894 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbcGKWi3 (ORCPT ); Mon, 11 Jul 2016 18:38:29 -0400 Received: by mail-oi0-f48.google.com with SMTP id u201so168862911oie.0 for ; Mon, 11 Jul 2016 15:38:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160711215009.4519-3-sboyd@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote: > The voltage ranges listed here are wrong. The pma8084 pldo > supports three different overlapping voltage ranges with > differing step sizes and the pma8084 ftsmps supports two. These > ranges can be seen in the "native" spmi regulator driver > (qcom_spmi-regulator.c) at pldo_ranges[] and ftsmps_ranges[] > respectively. Port these ranges over to the RPM SMD regulator > driver so that we list the appropriate set of supported voltages > on these types of regulators. > > Cc: Andy Gross > Cc: Bjorn Andersson > Fixes: ee01d0c91ef1 ("regulator: qcom-smd: Add support for PMA8084") > Signed-off-by: Stephen Boyd > static const struct regulator_desc pma8084_pldo = { > .linear_ranges = (struct regulator_linear_range[]) { > - REGULATOR_LINEAR_RANGE(750000, 0, 30, 25000), > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000), > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500), It was my understanding that the PMOS ldos only support 25mV and 50mV incremements. > + REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000), > + REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000), > }, > - .n_linear_ranges = 2, > - .n_voltages = 100, > + .n_linear_ranges = 3, > + .n_voltages = 164, > .ops = &rpm_smps_ldo_ops, Regards, Andy