From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH V8 7/9] vfio, platform: make reset driver a requirement by default Date: Wed, 13 Jul 2016 15:18:47 -0600 Message-ID: <20160713151847.0f131dd1@t450s.home> References: <1466437879-32182-1-git-send-email-okaya@codeaurora.org> <1466437879-32182-8-git-send-email-okaya@codeaurora.org> <20160623125955.647008cb@t450s.home> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49829 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbcGMVSy (ORCPT ); Wed, 13 Jul 2016 17:18:54 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@redhat.com, linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , linux-kernel@vger.kernel.org On Wed, 13 Jul 2016 16:48:32 -0400 Sinan Kaya wrote: > On 6/23/2016 2:59 PM, Alex Williamson wrote: > >> -static void vfio_platform_get_reset(struct vfio_platform_device *vdev) > >> > +static int vfio_platform_get_reset(struct vfio_platform_device *vdev) > >> > { > >> > if (vdev->acpihid) > >> > - return; > >> > + return vfio_platform_acpi_has_reset(vdev) ? 0 : -ENOENT; > >> > > >> > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > >> > &vdev->reset_module); > >> > @@ -140,6 +140,8 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev) > >> > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > >> > &vdev->reset_module); > >> > } > >> > + > >> > + return vdev->of_reset ? 0 : -ENOENT; > >> > } > > nit, this looks more like a: > > > > static bool vfio_platform_has_reset(...) > > ... > > return vfio_platform_acpi_has_reset() == 0; > > > > ... > > > > return vdev->of_reset != NULL > > > > Sorry, I didn't understand this comment. The code has get and put functions for DT. > These functions are not useful for ACPI. This is the reason for the above change. > > Can you be more specific? It was sort of cryptic, I'm not entirely sure I can make sense of it either. It think I was mainly suggesting that it looked more like a bool function so we could just return true/false, but we are actually setting the of_reset function as part of this, so there is a 'get' aspect. Feel free to ignore this comment. Thanks, Alex