From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback Date: Fri, 19 Aug 2016 09:12:50 +0530 Message-ID: <20160819034249.GS9681@localhost> References: <20160804125525.GF9681@localhost> <71a15611-645f-7523-1c26-14b420aff667@codeaurora.org> <20160804144003.GV1041@n2100.armlinux.org.uk> <20160808090203.GY9681@localhost> <21475c6e-a5f8-5125-3998-f3995ce67c4d@codeaurora.org> <20160810172805.GH9681@localhost> <20160819024853.GR9681@localhost> <8c096fee-9749-a7df-7e04-25d21c0ea9ac@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:36059 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbcHSDfA (ORCPT ); Thu, 18 Aug 2016 23:35:00 -0400 Content-Disposition: inline In-Reply-To: <8c096fee-9749-a7df-7e04-25d21c0ea9ac@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: Russell King - ARM Linux , linux-arm-msm@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Christopher Covington , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Thu, Aug 18, 2016 at 11:26:28PM -0400, Sinan Kaya wrote: > On 8/18/2016 10:48 PM, Vinod Koul wrote: > >> Keep a size limited list with error cookies and flush them in terminate all? > > I think so, terminate_all anyway cleans up the channel. Btw what is the > > behaviour on error? Do you terminate or somthing else? > > > > On error, I flush all outstanding transactions with an error code and I reset > the channel. After the reset, the DMA channel is functional again. The client > doesn't need to shutdown anything. You mean from the client context or driver? -- ~Vinod