From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Date: Tue, 30 Aug 2016 22:34:22 +0530 Message-ID: <20160830170422.GN9355@localhost> References: <1471927691-28827-1-git-send-email-okaya@codeaurora.org> <1471927691-28827-4-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:39019 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758212AbcH3Q4V (ORCPT ); Tue, 30 Aug 2016 12:56:21 -0400 Content-Disposition: inline In-Reply-To: <1471927691-28827-4-git-send-email-okaya@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Williams , Lars-Peter Clausen , Andy Shevchenko , Dave Jiang , linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: > spin_lock_init(&lldev->lock); > - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); ?? This is not described in changlog? If you are not using in anywhere else, then rst_task variable should be removed too.. -- ~Vinod