From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH V4 0/3] dmaengine: qcom_hidma: add error reporting Date: Wed, 31 Aug 2016 21:28:07 +0530 Message-ID: <20160831155807.GZ9355@localhost> References: <1472656229-12955-1-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:59686 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964880AbcHaPuD (ORCPT ); Wed, 31 Aug 2016 11:50:03 -0400 Content-Disposition: inline In-Reply-To: <1472656229-12955-1-git-send-email-okaya@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Sinan Kaya Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, Aug 31, 2016 at 11:10:26AM -0400, Sinan Kaya wrote: > Three changes in the error handling area: > > 1. There is a race condition between data transfer callback and descriptor > free code. The callback routine may decide to clear the resources even > though the descriptor has not yet been freed. > > 2. DMA Engine framework now supports direct error reporting to the client > via the callback. > > Pass the DMA errors to the client by passing a result argument. The HW > only supports a generic error when something goes wrong. That's why, > using DMA_TRANS_ABORTED all the time. > > 3. The HIDMA driver is capable of error detection. However, the error was > not being passed back to the client when tx_status API is called. Applied all, thanks -- ~Vinod