linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Iaroslav Gridin <voker57@gmail.com>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: msm8974: Add definitions for QCE & cryptobam
Date: Wed, 7 Sep 2016 19:20:26 +0300	[thread overview]
Message-ID: <20160907162025.3t5t6ghposbzc43r@localhost> (raw)
In-Reply-To: <32148db3-74b8-c81f-9688-b286d9516b9d@mm-sol.com>


> > +			clocks = <&gcc GCC_CE2_AHB_CLK>,
> > +				 <&gcc GCC_CE2_AXI_CLK>,
> > +				 <&gcc GCC_CE2_CLK>;
> > +			clock-names = "bam_clk", "axi_clk", "core_clk";
> > +			#dma-cells = <1>;
> > +			qcom,ee = <1>;
> > +			qcom,controlled-remotely;
> > +			};
> 
> indentation please.

Similar indentation (tabs then spaces to align) is used all over dts, am I doing it wrong or is
this bad practice?

Example @ line 334:

>				interrupts = <0 8 0x4>,
>					     <0 7 0x4>;

  reply	other threads:[~2016-09-07 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 15:37 [PATCH] ARM: dts: msm8974: Add definitions for QCE & cryptobam Iaroslav Gridin
2016-09-07 13:09 ` Stanimir Varbanov
2016-09-07 16:20   ` Iaroslav Gridin [this message]
2016-09-17  0:10   ` Stephen Boyd
2016-09-13  3:51 ` Bjorn Andersson
2016-09-15 21:18 ` Andy Gross
2016-09-16 11:59   ` Iaroslav Gridin
2016-09-16 17:38   ` Iaroslav Gridin
2016-09-16 18:50     ` Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160907162025.3t5t6ghposbzc43r@localhost \
    --to=voker57@gmail.com \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).