From mboxrd@z Thu Jan  1 00:00:00 1970
From: Iaroslav Gridin <voker57@gmail.com>
Subject: Re: [PATCH] ARM: dts: msm8974: Add definitions for QCE & cryptobam
Date: Wed, 7 Sep 2016 19:20:26 +0300
Message-ID: <20160907162025.3t5t6ghposbzc43r@localhost>
References: <20160830153740.13275-1-voker57@gmail.com>
 <32148db3-74b8-c81f-9688-b286d9516b9d@mm-sol.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-wm0-f50.google.com ([74.125.82.50]:38023 "EHLO
        mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756812AbcIGQUd (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Wed, 7 Sep 2016 12:20:33 -0400
Content-Disposition: inline
In-Reply-To: <32148db3-74b8-c81f-9688-b286d9516b9d@mm-sol.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org


> > +			clocks = <&gcc GCC_CE2_AHB_CLK>,
> > +				 <&gcc GCC_CE2_AXI_CLK>,
> > +				 <&gcc GCC_CE2_CLK>;
> > +			clock-names = "bam_clk", "axi_clk", "core_clk";
> > +			#dma-cells = <1>;
> > +			qcom,ee = <1>;
> > +			qcom,controlled-remotely;
> > +			};
> 
> indentation please.

Similar indentation (tabs then spaces to align) is used all over dts, am I doing it wrong or is
this bad practice?

Example @ line 334:

>				interrupts = <0 8 0x4>,
>					     <0 7 0x4>;